-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for line continuation #819
base: master
Are you sure you want to change the base?
Conversation
This feature is a minefield... |
I like this. It would also avoid the breaking change. Thank you for the linked info. Given that I manage to solve/avoid these problems, is this a wanted feature? I don't want to spend a lot of time working on a feature that would not be merged due to big-picture reasons. |
This is definitely a wanted feature. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Current behavior might be buggy. |
You can have a look at gwenn#3 (comment) , however it's mightly that the Layout requires reconstruction, and the continuation feature seems need to implement base on the new Layout. |
I've opened a new PR that implements span tracking first: #820 |
Adds support for line continuation in prompts, which can be used to achieve rectangular prompts.
Supersedes #338 & #372
Review notes:
input_multiline
example,breaking:
commit is the only breaking change that addscontinuation
param tofn readline
. I'm not fully confident that this feature is worth breaking the API over, but it seems most reasonable public API to me. That's because the continuation is usually dependent on the prompt.fn Editor::set_continuation
function. In that case, I can revert last two commits.I'm very invested in landing this PR and I'm willing to make changes.
TODO: