-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop emeritus leads from various group #1476
Conversation
Signed-off-by: Paul S. Schweigert <[email protected]>
Signed-off-by: Paul S. Schweigert <[email protected]>
Signed-off-by: Paul S. Schweigert <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: psschwei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bye bye 😢 |
/check-cla |
/easycla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rhuss is an active Knative contributor and a WG lead. Maybe he should be moved from owners to members?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see other WG leads are in members
, so, that makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or let me ask... What's owners
and what's members
here?
Owners --> TOC members?
Members --> TOC members + WG leads?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having owners doesn't really matter because it is a mailing list that the public can't join. owners can be moved to members and left empty entirely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either way, we can't just remove Roland here, as he isn't listed in members. That'll effectively remove him from the list.
So either restore him here, or move everyone to members as suggested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops! re-added roland, thanks for catching that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, this might be a blocker for #1383 |
Signed-off-by: Paul S. Schweigert <[email protected]>
Looks good to me, are there any changes still needed or can we merge this so that #1383 can move forwards? |
/lgtm Any further changes can be done with subsequent PRs |
Noticed some of these files were a bit out of date, so took a best guess at who should be dropped.
Wasn't sure if the admins for [email protected] are the TOC, so didn't update that one.
cc @knative/technical-oversight-committee @knative/productivity-leads