Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop emeritus leads from various group #1476

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

psschwei
Copy link
Contributor

@psschwei psschwei commented Dec 7, 2023

Noticed some of these files were a bit out of date, so took a best guess at who should be dropped.

Wasn't sure if the admins for [email protected] are the TOC, so didn't update that one.

cc @knative/technical-oversight-committee @knative/productivity-leads

Signed-off-by: Paul S. Schweigert <[email protected]>
Signed-off-by: Paul S. Schweigert <[email protected]>
Copy link

knative-prow bot commented Dec 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from krsna-m and upodroid December 7, 2023 17:41
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 7, 2023
@vagababov
Copy link
Contributor

Bye bye 😢

@aliok
Copy link
Member

aliok commented Dec 21, 2023

/check-cla

@cardil
Copy link
Contributor

cardil commented Dec 21, 2023

/easycla

Comment on lines -23 to -24
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhuss is an active Knative contributor and a WG lead. Maybe he should be moved from owners to members?!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see other WG leads are in members, so, that makes sense.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or let me ask... What's owners and what's members here?

Owners --> TOC members?
Members --> TOC members + WG leads?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having owners doesn't really matter because it is a mailing list that the public can't join. owners can be moved to members and left empty entirely.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way, we can't just remove Roland here, as he isn't listed in members. That'll effectively remove him from the list.

So either restore him here, or move everyone to members as suggested.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops! re-added roland, thanks for catching that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cardil @upodroid Are we good with this one? Sorry for the pressure, but I want to go ahead and work on #1383

@aliok
Copy link
Member

aliok commented Dec 21, 2023

FYI, this might be a blocker for #1383

Signed-off-by: Paul S. Schweigert <[email protected]>
@Cali0707
Copy link
Member

Cali0707 commented Jan 4, 2024

Looks good to me, are there any changes still needed or can we merge this so that #1383 can move forwards?

@dprotaso
Copy link
Member

/lgtm

Any further changes can be done with subsequent PRs

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2024
@knative-prow knative-prow bot merged commit 95069b9 into knative:main Jan 11, 2024
4 checks passed
@psschwei psschwei deleted the update-wg-leads-group branch April 8, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants