-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add xiangpingjiang to knative and knative-extensions #1488
Conversation
Signed-off-by: pingjiang <[email protected]>
Welcome @xiangpingjiang! It looks like this is your first PR to knative/community 🎉 |
Hi @xiangpingjiang. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
LGTM from my side! /cc @pierDipi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/cc @knative/technical-oversight-committee |
LGTM from my side too. Thanks a lot for your contributions on the OIDC work @xiangpingjiang so far! /lgtm |
That's so amazing! Thanks for all the work you have done @xiangpingjiang , so happy for you! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, pierDipi, xiangpingjiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
I'm adding myself as a knative and knative-sandbox member so I don't need to wait for the
ok-to-test
labels.My contributions so far have been:
eventing
client
docs
serving
cc @Cali0707 @creydr @dsimansk