add repository to the credentials prompt

[gauron99]

Added repository value (now it is registry/repository) to prompt for credentials where its used for printing out tto terminal "during the prompt" to make it easier for the user to see what he is trying to provide credentials for.

Additionally I have created a new issue that is a followup to this and its' purpose is to further optimize this "credentials" process

fix #2562

[knative-prow]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[codecov]

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.42%. Comparing base (cd24d85) to head (dd6a10e).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
cmd/prompt/prompt.go	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2596      +/-   ##
==========================================
+ Coverage   64.13%   65.42%   +1.28%     
==========================================
  Files         130      130              
  Lines       15516    15518       +2     
==========================================
+ Hits         9951    10152     +201     
+ Misses       4625     4389     -236     
- Partials      940      977      +37     

Flag	Coverage Δ
e2e-test	35.81% <11.11%> (-0.02%)	⬇️
e2e-test-oncluster	32.87% <11.11%> (+0.03%)	⬆️
e2e-test-oncluster-runtime	28.65% <11.11%> (?)
e2e-test-runtime-go	26.44% <11.11%> (?)
e2e-test-runtime-node	25.84% <11.11%> (?)
e2e-test-runtime-python	25.84% <11.11%> (?)
e2e-test-runtime-quarkus	25.99% <11.11%> (?)
e2e-test-runtime-rust	24.94% <11.11%> (?)
e2e-test-runtime-springboot	24.98% <11.11%> (?)
e2e-test-runtime-typescript	25.95% <11.11%> (?)
integration-tests	51.93% <33.33%> (+2.26%)	⬆️
unit-tests	50.93% <88.88%> (?)
unit-tests-macos-latest	?
unit-tests-ubuntu-latest	?
unit-tests-windows-latest	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gauron99]

@matejvasek what about this. I have changed the sole argument that needed it. Added a repository to it so now it is displayed when the prompt asks you for your credentials when trying to 'push' WITH the actual 'registry/repository'
Althought I had to change the prompt tests to reflect this as well

[matejvasek]

@gauron99

what about this. I have changed the sole argument that needed it.

This seems reasonable. Just call it repository instead of overly verbose registryWithRepo.

IMO that how our flag should have been called: instead of --registry we should have had --repository or --img-reposotry.

[gauron99]

@matejvasek @lkingland PTAL

[matejvasek]

/approve
/lgtm

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gauron99,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment