Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure private storage #3797

Merged
merged 2 commits into from
May 12, 2022
Merged

Azure private storage #3797

merged 2 commits into from
May 12, 2022

Conversation

bufke
Copy link
Contributor

@bufke bufke commented May 5, 2022

Description

Adds support for Azure in django-private-storage

Hacky things

Weird things

  • PrivateS3BotoStorage overrides a bunch of defaults of S3BotoStorage but I don't know why. Most of the overrides don't seem relevant. It's already being set in the base class. The claimed "differs from base class" are not accurate. AWS_PRIVATE_DEFAULT_ACL is None by default which uses the S3 default of private.

Related issues

Related to #3794

@bufke bufke requested a review from jnm May 5, 2022 20:54
@bufke bufke changed the base branch from master to beta May 5, 2022 20:54
@jnm jnm merged commit 7a4ae94 into beta May 12, 2022
@jnm jnm deleted the azure-private-storage branch May 12, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants