feat: Edit Collection & NFT UI #11171

hassnian · 2024-10-30T13:43:10Z

PR Type

Bugfix
Feature
Refactoring

Context

not closing some issues since some UI/UX changes may be needed

Screenshot 📸

My fix has changed something on UI;

Edit NFT

Edit Collection

Refresh Collection Nfts Metadata

…dexed

netlify · 2024-10-30T13:43:29Z

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	`da9cd4b`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/6745a78c9da64d0008ecab85
😎 Deploy Preview	https://deploy-preview-11171--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

…into issue-5286-1

composables/transaction/transactionUpdateCollection.ts

vikiival · 2024-10-31T11:52:46Z

Amazing ❤️❤️
I am just thinking how to add

also I would make the modal wider WDYT @exezbcz

…is changed

socket-security · 2024-11-18T05:36:30Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@kodadot1/[email protected]	None	`0`	23.2 kB	vikiival

🚮 Removed packages: npm/@kodadot1/[email protected]

View full report↗︎

…into issue-5286-1

types/index.ts

composables/transaction/transactionUpdateCollection.ts

vikiival · 2024-11-20T08:25:23Z

composables/transaction/types.ts

@@ -241,7 +241,7 @@ export interface ActionMintCollection {

 export enum Collections {


Why did you remove the set_max?

UPDATE_COLLECTION is the replacement for that action, or you mean it we should keep that and used it if the user only changes the max supply

yup I would keep it

what about something like this 492f13b since this is the only place where that would be used, alternatively I can just a the old action SET_MAX_SUPPLY and just call that

locales/en.json

vikiival

Some small things for clarification

vikiival · 2024-11-20T13:55:23Z

It would be nice to fix the test

vikiival · 2024-11-22T11:12:49Z

pls resolve conflicts

…nft-gallery into feature/init/swapLanding

hassnian · 2024-11-26T06:08:08Z

blocker #11187

edit:

fixed

ty: preschian

sonarqubecloud · 2024-11-26T10:49:34Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

hassnian added 9 commits October 28, 2024 17:09

add(collectinos): init new edit collection modal

ebbf6c5

add(collection): edit collection transaction

b90b894

add(transactionUpdateCollection.ts): collection banner in metadata

c7d369c

ref(transactionUpdateCollection.ts): one liner

193601f

fix(useTransaction.ts): api param type

3d9ec0c

fix(EditModal.vue): disabled computed

57c820a

add(HeroButtonEditCollection.vue): refresh page on collection data in…

b1d22cf

…dexed

fix(EditModal.vue): collection max overriden on image upload

cecd403

add(HeroButtons.vue): refresh collection metadata

8ec7cbc

hassnian added 4 commits October 31, 2024 06:42

Merge branch 'main' into issue-5286-1

ebe3879

add(EditModal.vue): into translation keys

fea4527

Merge branch 'issue-5286-1' of https://github.com/hassnian/nft-gallery …

b0b7ce5

…into issue-5286-1

add(EditModal.vue): capitalize text

5b5f880

vikiival reviewed Oct 31, 2024

View reviewed changes

composables/transaction/transactionUpdateCollection.ts Outdated Show resolved Hide resolved

This was linked to issues Oct 31, 2024

Collection Edit: Support Supply Update #11147

Closed

Collection Edit: Support Banner Update #11146

Closed

Collection Edit: Support Image Update #11145

Closed

hassnian added 10 commits November 1, 2024 17:57

add(GalleryItem): set collection metadata

dd0d332

fix(EditNftModal.vue): disabled computed and attributes updating

0991b28

add(GalleryItem): refresh page on metadata update

b7c6d17

ref(GalleryItemEditNftButton.vue): cleaner code

a9b7c25

update: edit collection and edit nft sign transaction modal

7a873f3

fix(EditModal.vue): submit button disabled on image change

3a47685

ref(transactionUpdateCollection.ts): update collection max if supply …

ececa74

…is changed

fix(HeroButtonEditCollection.vue): collection data refresh subscription

be4edc9

fix(GalleryItemEditNftButton.vue): invalid metadata case

64c8b89

fix(useGalleryItem.ts): refresh token on metdata update

33cc62d

hassnian changed the title ~~feat: Collection edit UI~~ feat: Edit Collection & NFT UI Nov 4, 2024

ref(CollectionCard.vue): use from

06a61e0

hassnian added 2 commits November 18, 2024 10:36

ref(CollectionCard.vue): use CollectionMetadata from hyperdata

cb1fbd3

Merge branch 'issue-5286-1' of https://github.com/hassnian/nft-gallery …

9c1706a

…into issue-5286-1

vikiival reviewed Nov 20, 2024

View reviewed changes

types/index.ts Show resolved Hide resolved

vikiival reviewed Nov 20, 2024

View reviewed changes

composables/transaction/transactionUpdateCollection.ts Show resolved Hide resolved

vikiival reviewed Nov 20, 2024

View reviewed changes

locales/en.json Show resolved Hide resolved

vikiival reviewed Nov 20, 2024

View reviewed changes

hassnian mentioned this pull request Nov 21, 2024

Sidebar interactions test failing #11184

Closed

vikiival requested a review from Jarsen136 November 22, 2024 11:24

Jarsen136 approved these changes Nov 22, 2024

View reviewed changes

hassnian and others added 7 commits November 23, 2024 07:59

Merge branch 'feature/init/swapLanding' of https://github.com/roiLeo/…

9db9aa4

…nft-gallery into feature/init/swapLanding

fix(GalleryItemEditNftButton.vue): key nft metadata

8907dc0

ref(transaction): transactionUpdateCollection optional update metadata

492f13b

Trigger Build

46a84dd

fix: pnpm-lock.yaml failing build

2723532

Merge branch 'main' into issue-5286-1

3b977bc

ref: update pnpm-lock.yaml

f84802d

ref: soft update pnpm-lock.yaml

da9cd4b

hassnian added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Nov 26, 2024

vikiival merged commit df25797 into kodadot:main Nov 26, 2024
22 of 23 checks passed

This was referenced Nov 28, 2024

(beta): November 2024 Elderberry 🍇🖤 #11194

Merged

(prod): December 2024 Elderberry 🍇🖤 #11205

Merged

This was referenced Dec 10, 2024

(beta): 32% of December 2024 Fig 💜 #11232

Merged

(prod): 32 % December 2024 Fig 💜 #11233

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Edit Collection & NFT UI #11171

feat: Edit Collection & NFT UI #11171

hassnian commented Oct 30, 2024 •

edited

Loading

netlify bot commented Oct 30, 2024 •

edited

Loading

vikiival commented Oct 31, 2024

socket-security bot commented Nov 18, 2024 •

edited

Loading

vikiival Nov 20, 2024

hassnian Nov 20, 2024 •

edited

Loading

vikiival Nov 22, 2024

hassnian Nov 23, 2024 •

edited

Loading

vikiival left a comment

vikiival commented Nov 20, 2024

vikiival commented Nov 22, 2024

hassnian commented Nov 26, 2024 •

edited

Loading

sonarqubecloud bot commented Nov 26, 2024

		@@ -241,7 +241,7 @@ export interface ActionMintCollection {

		export enum Collections {

feat: Edit Collection & NFT UI #11171

feat: Edit Collection & NFT UI #11171

Conversation

hassnian commented Oct 30, 2024 • edited Loading

PR Type

Context

Screenshot 📸

Edit NFT

Edit Collection

Refresh Collection Nfts Metadata

netlify bot commented Oct 30, 2024 • edited Loading

✅ Deploy Preview for koda-canary ready!

vikiival commented Oct 31, 2024

socket-security bot commented Nov 18, 2024 • edited Loading

vikiival Nov 20, 2024

Choose a reason for hiding this comment

hassnian Nov 20, 2024 • edited Loading

Choose a reason for hiding this comment

vikiival Nov 22, 2024

Choose a reason for hiding this comment

hassnian Nov 23, 2024 • edited Loading

Choose a reason for hiding this comment

vikiival left a comment

Choose a reason for hiding this comment

vikiival commented Nov 20, 2024

vikiival commented Nov 22, 2024

hassnian commented Nov 26, 2024 • edited Loading

sonarqubecloud bot commented Nov 26, 2024

Quality Gate passed

hassnian commented Oct 30, 2024 •

edited

Loading

netlify bot commented Oct 30, 2024 •

edited

Loading

socket-security bot commented Nov 18, 2024 •

edited

Loading

hassnian Nov 20, 2024 •

edited

Loading

hassnian Nov 23, 2024 •

edited

Loading

hassnian commented Nov 26, 2024 •

edited

Loading