refactor: remove abstracts/variables #11350
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e CSS variables in DropCard, ActiveCount, and DesktopControls components
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Deploying koda-art-prod with
|
| Latest commit: |
6f48009
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ae7ff598.kodaart-production.pages.dev |
| Branch Preview URL: | https://refactor--remove-abstracts-v.kodaart-production.pages.dev |
preschian
requested review from
Jarsen136 and
hassnian
and removed request for
a team
|
hassnian
reviewed
Jan 10, 2025
Comment on lines
-200
to
+199
| padding-top: $navbar-desktop-min-height; | ||
| padding-top: 80px; |
There was a problem hiding this comment.
not needed anywhere else ?
Comment on lines
+78
to
+79
| // until 1215px | ||
| @media screen and (max-width: 1215px) { |
There was a problem hiding this comment.
can we reuse this number somehow
| @@ -98,7 +87,8 @@ defineProps<{ | |||
| } | |||
| } | |||
| @include until-widescreen { | |||
| // until 1215px | |||
| @media screen and (max-width: 1215px) { | |||
Jarsen136
reviewed
Jan 10, 2025
There was a problem hiding this comment.
small color issue here
https://deploy-preview-11350--koda-canary.netlify.app/ahp/explore/items?listed=true
Comment on lines
150
to
154
| .is-ellipsis { | ||
| @include mobile { | ||
| @media (max-width: 640px) { | ||
| white-space: unset; | ||
| } | ||
| } |
There was a problem hiding this comment.
is-ellipsis does not seem to be used in this component.
Comment on lines
64
to
69
| <style scoped lang="scss"> | ||
| @import '@/assets/styles/abstracts/variables'; | ||
| .is-ellipsis { | ||
| @include mobile { | ||
| @media (max-width: 640px) { | ||
| white-space: unset; | ||
| } | ||
| } |
There was a problem hiding this comment.
is-ellipsis does not seem to be used in this component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the Koda - Generative Art Marketplace.
👇 __ Let's make a quick check before the contribution.
PR Type
Context
abstracts/variablesin some files. part of CSS Refactoring step 1 #8071 and remove bulma css #9013tested on:
lmk if I miss in some page