unique tokenEntity id by both image and media #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tested on local machine on AHK |
vikiival
requested changes
Feb 23, 2024
src/mappings/shared/token/utils.ts
Outdated
Comment on lines
8
to
15
| export function generateTokenId(collectionId: string, nft: NE): string | undefined { | ||
| if (!nft.image && !nft.media) { | ||
| warn(OPERATION, `MISSING NFT MEDIA ${nft.id}`) | ||
| return undefined | ||
| } | ||
|
|
||
| return nftMedia | ||
| const image = nft.image ?? '' | ||
| const media = nft.media ?? '' | ||
| const mediaHash = md5(image + media) |
There was a problem hiding this comment.
what the difference?
md5(meta.image) + ':' md5(meta.animation_url) is opaque just same as md5(image + media) is opaque
also both image and animation_utl can be null | undefined
There was a problem hiding this comment.
plus it should be unique per collection
could be a situation where 2 different collection each have same artwork
There was a problem hiding this comment.
for the sake of speeding things along i complied
but i do not understand what difference does it make
…nEntity-is-merging-nfts
vikiival
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Context
change from
tokenId = <collection_id>-<md5(image ?? media)>to
tokenId = <collectionId>-md5(imge + media)Did your issue had any of the "$" label on it?