Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify stream capture and remove thread #213

Merged
merged 3 commits into from
Jan 3, 2025
Merged

Conversation

edgarriba
Copy link
Member

@edgarriba edgarriba commented Jan 2, 2025

This pull request includes significant refactoring and simplification of the StreamCapture implementation in the kornia-io crate, as well as minor changes in several example files to remove unnecessary mutability.

Refactoring and simplification of StreamCapture:

Removal of unnecessary mutability in example files:

  • Removed mut from webcam and capture variable declarations in multiple example files (examples/features/src/main.rs, examples/filters/src/main.rs, examples/rtspcam/src/main.rs, examples/video_write/src/main.rs, examples/webcam/src/main.rs, [1] [2] [3] [4] [5].

@edgarriba edgarriba enabled auto-merge (squash) January 3, 2025 13:12
@edgarriba edgarriba merged commit 746f5fb into main Jan 3, 2025
12 checks passed
@edgarriba edgarriba deleted the simplify-streamcapture branch January 3, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants