Simplify stream capture and remove thread #213
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant refactoring and simplification of the
StreamCapture
implementation in thekornia-io
crate, as well as minor changes in several example files to remove unnecessary mutability.Refactoring and simplification of
StreamCapture
:Arc
andMutex
forlast_frame
and simplified theStreamCapture
struct by replacinglast_frame
andhandle
withappsink
(crates/kornia-io/src/stream/capture.rs
, crates/kornia-io/src/stream/capture.rsL1-R8).start
method by removing the thread handling and usingbus.set_sync_handler
to handle bus messages (crates/kornia-io/src/stream/capture.rs
, crates/kornia-io/src/stream/capture.rsL38-R47).grab
method to useappsink.try_pull_sample
instead of accessinglast_frame
(crates/kornia-io/src/stream/capture.rs
, crates/kornia-io/src/stream/capture.rsL106-R85).extract_image_frame
method by directly using the sample parameter instead of pulling it fromappsink
(crates/kornia-io/src/stream/capture.rs
, crates/kornia-io/src/stream/capture.rsL163-R107).Removal of unnecessary mutability in example files:
mut
fromwebcam
andcapture
variable declarations in multiple example files (examples/features/src/main.rs
,examples/filters/src/main.rs
,examples/rtspcam/src/main.rs
,examples/video_write/src/main.rs
,examples/webcam/src/main.rs
, [1] [2] [3] [4] [5].