handle null values for the build started and finished dates

koyeb · Aug 28, 2024 · 6852d03 · 6852d03
1 parent 5d5ad4c
commit 6852d03
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/src/api/mappers/deployment.ts b/src/api/mappers/deployment.ts
@@ -79,6 +79,7 @@ function transformComputeDeployment(deployment: ApiDeployment): ComputeDeploymen
     return {
       status: lowerCase(stage.status!),
       sha: deployment.provisioning_info?.sha,
+      // the API actually returns null
       startedAt: stage.started_at!,
       finishedAt: stage.finished_at!,
     };

diff --git a/src/api/model.ts b/src/api/model.ts
@@ -162,8 +162,8 @@ export type DeploymentStatus =
 export type DeploymentBuild = {
   status: DeploymentBuildStatus;
   sha?: string;
-  startedAt: string;
-  finishedAt: string;
+  startedAt: string | null;
+  finishedAt: string | null;
 };
 
 export type DeploymentBuildStatus = 'unknown' | 'running' | 'failed' | 'completed' | 'aborted';

diff --git a/src/modules/deployment/deployment-logs/deployment-logs.tsx b/src/modules/deployment/deployment-logs/deployment-logs.tsx
@@ -21,6 +21,7 @@ import { useObserve } from 'src/hooks/lifecycle';
 import { useLogs } from 'src/hooks/logs';
 import { useNow } from 'src/hooks/timers';
 import { Translate } from 'src/intl/translate';
+import { assert } from 'src/utils/assert';
 
 import { BuildLogs } from './build-logs';
 import { Replicas } from './replicas';
@@ -200,7 +201,7 @@ function BuildSectionHeaderEnd({ expanded, deployment }: BuildSectionHeaderEndPr
     return;
   }
 
-  if (status === 'running' && expanded) {
+  if (status === 'running' && expanded && build.startedAt !== null) {
     const duration = Math.floor((now.getTime() - new Date(build.startedAt).getTime()) / 1000);
 
     return (
@@ -242,6 +243,9 @@ function getBuildStatus(deployment: ComputeDeployment): DeploymentBuildStatus |
 }
 
 function elapsed({ startedAt, finishedAt }: DeploymentBuild) {
+  assert(startedAt !== null);
+  assert(finishedAt !== null);
+
   return (new Date(finishedAt).getTime() - new Date(startedAt).getTime()) / 1000;
 }