-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1. Add CRDs for MetadataProfile #1434
base: mvp_demo
Are you sure you want to change the base?
1. Add CRDs for MetadataProfile #1434
Conversation
a7b4015
to
654befc
Compare
Which file is currently being used for ROS and the general use case? |
"query_variables": [ | ||
{ | ||
"name": "namespacesAcrossCluster", | ||
"datasource": "prometheus", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The datasource should also be available at the global level. In the query variables, the datasource should not be mandatory; if not specified, it will default to the global level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added datasource
field at the global level
Can you please include MD file with this PR |
|
Added |
Description
This PR includes:
Fixes # (issue)
Type of change
How has this been tested?
Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.
Test Configuration
Checklist 🎯
Additional information
.