2. Add abstractions for MetadataProfile #1440
Open
+466
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
msvinaykumar
reviewed
Jan 8, 2025
| '}'; | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
Added missing EOF
msvinaykumar
reviewed
Jan 8, 2025
|
|
||
| private final List<String> mandatoryQueryVariables = new ArrayList<>(Arrays.asList( | ||
| AnalyzerConstants.AutotuneObjectConstants.NAME, | ||
| AnalyzerConstants.AutotuneObjectConstants.DATASOURCE, |
There was a problem hiding this comment.
The datasource should also be available at the global level. In the query variables, the datasource should not be mandatory; if not specified, it will default to the global level.
There was a problem hiding this comment.
Updated the validation of datasource field at the global level
msvinaykumar
reviewed
Jan 8, 2025
| private static final Logger LOGGER = LoggerFactory.getLogger(MetadataProfileValidation.class); | ||
| private boolean success; | ||
| private String errorMessage; | ||
| private final Map<String, MetadataProfile> metadataProfilesMap; |
There was a problem hiding this comment.
why hashMap ? can we have String and MetadataProfile variable instead
There was a problem hiding this comment.
HashMap will store all the metadata profiles created.. helping in validation with few database calls and also will be used in Create and List REST APIs in the subsequent PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes abstractions for MetadataProfile:
MetadataProfilebeing the base class.MetadataProfileValidationandMetadataProfileUtilclasses for validating metadata profile and fields.Fixes # (issue)
Type of change
How has this been tested?
Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.
Test Configuration
Checklist 🎯
Additional information
.