Add Bone Search #85
Open
Add Bone Search #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bullet will only show if the text matches. - Selected will show if it or a descendant is the current target. + OpenOnArrow still works if Bullet is shown in its place. ! Unsure about the style in themselves, but they should be uniquely distinct from each other.
* Unsure on preference, but mainly for selecting bones when the empty space is selected... rather than the text.
* Bullet would have shown as if it had children to expand upon.
* new enum added specific for selection and query results
* search results for both are quite agressive when adding the icons * intention is to have colors mapped to these results and then pick the first one it matches to * additional possibility to add ancestor query results on top of child results
sudojunior
force-pushed
the
feat/bone-search
branch
from
c0c4aa4 to
19e24e0
Compare
sudojunior
commented
Jun 24, 2023
Comment on lines
69
to
74
| var criteria = HighlightCriteria.None; | ||
|
|
||
| var show = DrawBoneNode(bone, flag, () => OverlayWindow.SetGizmoOwner(bone.UniqueName)); | ||
| if (show) { | ||
| if (isSelected) criteria ^= HighlightCriteria.Selected; | ||
| if (isQueried) criteria ^= HighlightCriteria.Queried; | ||
| if (hasChildSelected) criteria ^= HighlightCriteria.ChildSelected; | ||
| if (hasChildInQuery) criteria ^= HighlightCriteria.ChildQueried; |
There was a problem hiding this comment.
Attempts to unify this into a single method, went well initially - but hit a wall with CS0315 when the generic was not satisfied with using the enum (the XOR operator wasn't satisfied either, which would have required each value of the enum to be type cast as an integer).
var criteria = ApplyMulti(
HighlightCriteria.None,
new [] {
(HighlightCriteria.Selected, Skeleton.IsBoneSelected(bone)),
(HighlightCriteria.Queried, BoneDoesMatch(bone)),
(HighlightCriteria.ChildSelected, decendents.Any(BoneDoesMatch)),
(HighlightCriteria.ChildQueried, decendents.Any(bone => Skeleton.IsBoneSelected(bone)))
}
);
private static T ApplyMulti<T>(T initial, (T, bool)[] pairs) where T : IBitwiseOperators<T, T, T> {
T result = initial;
foreach (var (value, condition) in pairs) {
if (condition) result ^= value;
}
return result;
}The use of an array only for this, would also have been excessive for its repeated calls, overall performance and impact on garbage collection.
Fayti1703
reviewed
Jun 25, 2023
Co-Authored-By: Fayti1703 <[email protected]>
Co-Authored-By: Fayti1703 <[email protected]>
Co-Authored-By: Fayti1703 <[email protected]>
Co-Authored-By: Fayti1703 <[email protected]>
Co-Authored-By: Fayti1703 <[email protected]>
sudojunior
commented
Jun 25, 2023
| private static Vector2 _FrameMin; | ||
| private static Vector2 _FrameMax; | ||
|
|
||
| private static string SearchText = ""; | ||
|
|
||
| public static unsafe void Draw(Actor* actor) { |
There was a problem hiding this comment.
IDE0036 was raised in accordance with .editorconfig.
Suggested change
| public static unsafe void Draw(Actor* actor) { | |
| public unsafe static void Draw(Actor* actor) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SearchTextmatches regardless of text case. (Thanks @Fayti1703)Changes between ab3c6a1...19e24e0
ImGuiTreeNodeFlagswas abandoned for a new enum associated to bone relationships.This currently encompasses Self and Child / Descendant, but can be expanded to include:
FontAwesomeIconto describe its association, if any exists - but can be changed to use colours or utilize both in varying capacities.Representation is expected to change to be more accessible, as is the core functionality and quality of code if this is to merge.