KTOR-8080 Update Apache HttpClient to v5.4.1 #4485
Conversation
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
|
Note: Fixes to be cherry-picked 127adc7 @e5l, I've checked and they haven't released the API fix yet. Probably it will be released with a minor version as it contains API changes. However, they only "rename" one function so the rest of my commit will stay the same. Considering we don't know how soon the next minor version will be released I'd suggest merging this update with my fixes containing a "TODO". |
|
@osipxd, sure. let's do this |
renovate
bot
force-pushed
the
renovate/apache5
branch
from
31590d7 to
8553727
Compare
renovate
bot
force-pushed
the
renovate/apache5
branch
from
8553727 to
aa3e8f2
Compare
osipxd
force-pushed
the
renovate/apache5
branch
from
aa3e8f2 to
4bed544
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
| @@ -89,6 +93,8 @@ internal class Apache5Engine(override val config: Apache5EngineConfig) : HttpCli | |||
| ClientTlsStrategyBuilder.create() | |||
| .setSslContext(config.sslContext ?: SSLContexts.createSystemDefault()) | |||
| .setTlsVersions(TLS.V_1_3, TLS.V_1_2) | |||
| // TODO: Remove apply after https://github.com/apache/httpcomponents-client/pull/588 merged | |||
| .apply { setHostnameVerificationPolicy(HostnameVerificationPolicy.BOTH) } | |||
There was a problem hiding this comment.
Should we make this value configurable?
There was a problem hiding this comment.
Could you check docs for the added field?
osipxd
force-pushed
the
renovate/apache5
branch
2 times, most recently
from
0f1655b to
be57cf3
Compare
osipxd
force-pushed
the
renovate/apache5
branch
from
be57cf3 to
dc6d571
Compare
| @@ -89,6 +93,8 @@ internal class Apache5Engine(override val config: Apache5EngineConfig) : HttpCli | |||
| ClientTlsStrategyBuilder.create() | |||
| .setSslContext(config.sslContext ?: SSLContexts.createSystemDefault()) | |||
| .setTlsVersions(TLS.V_1_3, TLS.V_1_2) | |||
| // TODO: Remove apply after https://github.com/apache/httpcomponents-client/pull/588 merged | |||
| .apply { setHostnameVerificationPolicy(HostnameVerificationPolicy.BOTH) } | |||
osipxd
force-pushed
the
renovate/apache5
branch
2 times, most recently
from
402b165 to
52fe886
Compare
osipxd
force-pushed
the
renovate/apache5
branch
from
52fe886 to
61e9c01
Compare
osipxd
changed the title
This PR contains the following updates:
5.3.1->5.4.1Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.