KTOR-8083 Refactor automatic targets configuration #4616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osipxd
force-pushed
the
osipxd/autoconfigure-targets
branch
from
9a5d076 to
ee667e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Infrastructure
Motivation
KTOR-8083 Refactor automatic targets configuration
Solution
I've introduced
KtorTargetsto encapsulate targets configuring logic.Instead of manually created boolean flags for each target type, we rely on the actual hierarchy. Unfortunately, it is not possible to access this hierarchy in KGP, so I had to introduce
KotlinHierarchyTrackerremembering the hierarchy configured in theKotlinHierarchyTemplate.It's better to review commit by commit.