-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert #3782 "Added Pipelines v2 installation pages" #3791
Revert #3782 "Added Pipelines v2 installation pages" #3791
Conversation
@hbelmiro as I was saying in #3782 (comment), the PR #3782 was unacceptable for a few reasons and needs to be reverted ASAP:
|
2bd812b
to
5da10e2
Compare
@andreyvelich @rimolive either of you could also approve this PR, because it's very important that we revert soon. |
Also @kubeflow/pipelines might be interested to see that we are reverting a strange PR in the KFP docs. |
@thesuperzapper Why reverting the change instead of fixing the missing links? I just checked the docs and I could not find any missing/broken link so please point me to these ones so we can fix asap. |
You are not reading my comment #3791 (comment), the primary issue is that it's not acceptable to move V1 docs into the V2 section without regard for the content. Also, here is a list of links that are now 404:
But even if you had created the appropriate redirects, I would still be suggesting a revert, because it's just not helpful to move docs so that they become incorrect (in the wrong section). |
@rimolive please don't try and defend the PR, just accept the reverse and make a new one, everyone makes mistakes. It was never acceptable to randomly move V1 docs into the V2 section. |
@rimolive @thesuperzapper I'm approving this revert and will create a new installation page for v2 with minimal information to install v2. We can iterate later. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hbelmiro The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@thesuperzapper can you please rebase? |
This reverts commit 5765bfa Signed-off-by: Mathew Wicks <[email protected]>
5da10e2
to
e2352bc
Compare
@hbelmiro I have rebased the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Reverts #3782
Please see #3782 (comment).