-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support the Continuous Scanning capability #323
Conversation
PR Analysis
PR Feedback
How to use
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
I will approve after we change the images to the official released images
I apologize, I re-requested review for the wrong PR 🤦♂️ |
charts/kubescape-operator/README.md
Outdated
|
||
## Installation | ||
|
||
Continuous Scanning is built into the Kubescape Operator Helm chart. To use this capibility, you only need to enable it. Start by navigating to the `values.yaml` file and make sure that the corresponding `capabilities.continuousScan` key is set to `enabled`, like so: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Continuous Scanning is built into the Kubescape Operator Helm chart. To use this capibility, you only need to enable it. Start by navigating to the `values.yaml` file and make sure that the corresponding `capabilities.continuousScan` key is set to `enabled`, like so: | |
Continuous Scanning is built into the Kubescape Operator Helm chart. To use this capability, you only need to enable it. Start by navigating to the `values.yaml` file and make sure that the corresponding `capabilities.continuousScan` key is set to `enabled`, like so: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for noticing! Fixed in latest.
This commit adds support for Continuous Scanning. It exposes new values that control: - whether to enable Continuous Scanning - which resources to monitor. Signed-off-by: Vlad Klokun <[email protected]>
d8fccc8
to
7982291
Compare
# Matching rules for the monitored resources. | ||
# Kubescape will watch resources of every provided GVR across the provided | ||
# namespaces. | ||
matchingRules: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vladklokun I'm not sure why this should be in the values file.
We don't want users to change it...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this to the values.yaml
file so that we can change the monitored GVRs more conveniently. I wouldn’t overestimate how often people change the deeply-buried configurables in Helm charts.
7982291
to
e1201d6
Compare
Signed-off-by: Vlad Klokun <[email protected]>
Closes #290. Signed-off-by: Vlad Klokun <[email protected]>
Signed-off-by: Vlad Klokun <[email protected]>
Signed-off-by: Vlad Klokun <[email protected]>
e1201d6
to
6e79b74
Compare
PR Type:
Enhancement
PR Description:
This PR introduces the Continuous Scanning feature in Kubescape, a tool for Kubernetes security. The main changes include:
Once kubescape/storage#59 and kubescape/operator#174 are merged, we can use our proper Quay images.
PR Main Files Walkthrough:
files:
charts/kubescape-operator/README.md
: Added extensive documentation on the Continuous Scanning feature, including its installation, accessing results, and how it works.charts/kubescape-operator/templates/configs/matchingRules-configmap.yaml
: Introduced a new ConfigMap for matching rules related to continuous scanning.charts/kubescape-operator/templates/operator/deployment.yaml
: Updated the operator deployment to include the new ConfigMap for continuous scanning.charts/kubescape-operator/values.yaml
: Added new configurations for the continuous scanning feature, including the ConfigMap name and matching rules. Also updated the operator image repository and tag.User Description:
Overview
This PR adds support for Continuous Scanning. It exposes new values
that control:
I left some docs in the README before we merge kubescape/kubescape.io#25. But after we merge it, I will remove the docs from the README and provide the links to the new documentation.