Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for service discovery v2 #337

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Support for service discovery v2 #337

merged 2 commits into from
Nov 21, 2023

Conversation

amirmalka
Copy link
Contributor

@amirmalka amirmalka commented Nov 21, 2023

Overview

  • Updated service discovery job to V2
  • Bump component versions with support for SD v2

@amirmalka amirmalka force-pushed the service-discovery-v2 branch from 5f9da0a to 9fc266a Compare November 21, 2023 12:48
@amirmalka amirmalka changed the title bump component version with support for service discovery v2 Support for service discovery v2 Nov 21, 2023
@amirmalka amirmalka force-pushed the service-discovery-v2 branch from 9fc266a to e8499cf Compare November 21, 2023 12:49
@amirmalka amirmalka marked this pull request as ready for review November 21, 2023 12:49
@codiumai-pr-agent-free codiumai-pr-agent-free bot added the enhancement New feature or request label Nov 21, 2023
@amirmalka amirmalka requested a review from matthyx November 21, 2023 12:50
Copy link

PR Analysis

  • 🎯 Main theme: Updating service discovery API path and component versions
  • 📝 PR summary: This PR updates the service discovery API path from v1 to v2 in the job.yaml file and also updates the versions of various components in the values.yaml file, including kubescape, operator, kubevuln, kollector, and gateway.
  • 📌 Type of PR: Enhancement
  • 🧪 Relevant tests added: No
  • ⏱️ Estimated effort to review [1-5]: 2, because the changes are straightforward and involve updating versions and API paths.
  • 🔒 Security concerns: No security concerns found

PR Feedback

  • 💡 General suggestions: The changes made in this PR are straightforward and do not seem to introduce any major issues. However, it would be beneficial to include a brief explanation of why these changes were necessary, especially the update from v1 to v2 of the service discovery API. This would help reviewers understand the context and potential impact of the changes.

  • 🤖 Code feedback:

    • relevant file: charts/kubescape-operator/templates/servicediscovery/job.yaml
      suggestion: Ensure that the updated service discovery API (v2) is fully compatible with the existing system and that all necessary adjustments have been made for the change. [important]
      relevant line: - -path=api/v2/servicediscovery

    • relevant file: charts/kubescape-operator/values.yaml
      suggestion: Confirm that the updated versions of the components (kubescape, operator, kubevuln, kollector, and gateway) have been thoroughly tested and are stable for use. [important]
      relevant line: tag: v3.0.2-prerelease

How to use

Instructions

To invoke the PR-Agent, add a comment using one of the following commands:
/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs: Generate docstring for new components introduced in the PR.
/generate_labels: Generate labels for the PR based on the PR's contents.
see the tools guide for more details.

To edit any configuration parameter from the configuration.toml, add --config_path=new_value.
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, add a /config comment.

Signed-off-by: Amir Malka <[email protected]>
@amirmalka
Copy link
Contributor Author

@amirmalka amirmalka merged commit 621c952 into main Nov 21, 2023
5 checks passed
@amirmalka amirmalka deleted the service-discovery-v2 branch November 28, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants