Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image pull secret generation using provided credentials #554

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

amirmalka
Copy link
Contributor

Overview

This update enhances the handling of imagePullSecrets by allowing users to generate an image pull secret dynamically based on provided credentials. Previously, the imagePullSecrets value was limited to referencing an existing secret. With this change, users can specify credentials and the chart will generate the required secret.

@amirmalka
Copy link
Contributor Author

amirmalka commented Dec 1, 2024

@matthyx WDYT? I did consider "merging" the imagePullSecrets to a single value but ended up with this...

@amirmalka amirmalka requested a review from matthyx December 1, 2024 14:12
@amirmalka amirmalka force-pushed the image-pull-secret-generation branch from 2730425 to 522ce95 Compare December 1, 2024 14:16
Signed-off-by: Amir Malka <[email protected]>
Copy link

gitguardian bot commented Dec 4, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14746536 Triggered Kubernetes Docker Secret ecb3f5e charts/kubescape-operator/tests/snapshot/snapshot_test.yaml.snap View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@matthyx matthyx merged commit 75a66a2 into main Dec 4, 2024
7 checks passed
@matthyx matthyx deleted the image-pull-secret-generation branch December 4, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants