increment resourceVersion on successful updates #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthyx
force-pushed
the
resourceversion
branch
from
b528053 to
07a6c5f
Compare
|
Summary:
|
matthyx
force-pushed
the
resourceversion
branch
from
07a6c5f to
f2f584c
Compare
|
Summary:
|
matthyx
force-pushed
the
resourceversion
branch
from
f2f584c to
6bd4dee
Compare
|
Summary:
|
matthyx
force-pushed
the
resourceversion
branch
from
6bd4dee to
2273e9d
Compare
|
Summary:
|
matthyx
force-pushed
the
resourceversion
branch
from
2273e9d to
ae6ee96
Compare
|
Summary:
|
matthyx
commented
Aug 19, 2024
| // check if the object is the same as the original | ||
| orig := origState.obj.DeepCopyObject() // FIXME this is expensive | ||
| _ = s.processor.PreSave(orig) | ||
| if reflect.DeepEqual(orig, ret) { |
There was a problem hiding this comment.
this saves us a lot of writes
amirmalka
previously approved these changes
Aug 20, 2024
|
Summary:
|
Signed-off-by: Matthias Bertschy <[email protected]>
Signed-off-by: Matthias Bertschy <[email protected]>
matthyx
force-pushed
the
resourceversion
branch
from
6876158 to
7834c1a
Compare
|
Summary:
|
|
Summary:
|
amirmalka
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
once released we can simplify https://github.com/kubescape/synchronizer/blame/f72c82a585f9c3469e9d48740efb2f97998a8724/tests/synchronizer_integration_test.go#L1323