Fix/empty SBOM

[dwertent]

User description

Sorry, we do not accept changes directly against this repository. Please see
CONTRIBUTING.md for information on where and how to contribute instead.

---

Type

Bug fix, Enhancement

---

Description

This PR includes several bug fixes and enhancements:

• Added a condition to handle cases where the type is not set in the unpackSrcMetadata function in pkg/apis/softwarecomposition/syfttypes.go.
• Replaced the usage of instanceidhandler with helpersv1 for accessing various metadata keys in pkg/cleanup/cleanup.go.
• Added support for init containers in pkg/cleanup/discovery.go, allowing the system to handle init containers in addition to regular containers.
• Updated the required fields for several schemas in pkg/generated/openapi/zz_generated.openapi.go. The policyRef field is no longer required for GeneratedNetworkPolicy, and the relevant field is no longer required for VulnerabilitiesComponents and VulnerabilityCounters.
• Updated the version of the kubescape/k8s-interface package from v0.0.154 to v0.0.158-0.20240117162237-b087cd69bcf1 in go.mod and go.sum.

---

Changes walkthrough

	Relevant files
Bug fix	syfttypes.go                                                                                                pkg/apis/softwarecomposition/syfttypes.go Added a condition to return nil when the type is not set in the unpackSrcMetadata function. This handles cases where the object returned from the watcher does not have the type set. +5/-0 zz_generated.openapi.go                                                                          pkg/generated/openapi/zz_generated.openapi.go Updated the required fields for several schemas. The policyRef field is no longer required for GeneratedNetworkPolicy, and the relevant field is no longer required for VulnerabilitiesComponents and VulnerabilityCounters. +5/-6
Enhancement	cleanup.go                                                                                                    pkg/cleanup/cleanup.go Replaced the usage of instanceidhandler with helpersv1 for accessing various metadata keys. This change is reflected in multiple functions within the file. +9/-9 discovery.go                                                                                                pkg/cleanup/discovery.go Added support for init containers in the fetchWlidsFromRunningWorkloads and fetchInstanceIdsAndImageIdsAndReplicasFromRunningPods functions. This allows the system to handle init containers in addition to regular containers. +31/-0
Dependencies	go.mod                                                                                                            go.mod Updated the version of the kubescape/k8s-interface package from v0.0.154 to v0.0.158-0.20240117162237-b087cd69bcf1. +1/-1 go.sum                                                                                                            go.sum Updated the checksums for the kubescape/k8s-interface package to reflect the version update in go.mod. +2/-2

---

✨ Usage guide:

---

Overview:
The describe tool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.

When commenting, to edit configurations related to the describe tool (pr_description section), use the following template:

/describe --pr_description.some_config1=... --pr_description.some_config2=...

With a configuration file, use the following template:

[pr_description]
some_config1=...
some_config2=...

Enabling\disabling automation When you first install the app, the default mode for the describe tool is: pr_commands = ["/describe --pr_description.add_original_user_description=true" "--pr_description.keep_original_user_title=true", ...] meaning the describe tool will run automatically on every PR, will keep the original title, and will add the original user description above the generated description. Markers are an alternative way to control the generated description, to give maximal control to the user. If you set: pr_commands = ["/describe --pr_description.use_description_markers=true", ...] the tool will replace every marker of the form pr_agent:marker_name in the PR description with the relevant content, where marker_name is one of the following: type: the PR type. summary: the PR summary. walkthrough: the PR walkthrough. Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.

Custom labels The default labels of the describe tool are quite generic: [Bug fix, Tests, Enhancement, Documentation, Other]. If you specify custom labels in the repo's labels page or via configuration file, you can get tailored labels for your use cases. Examples for custom labels: Main topic:performance - pr_agent:The main topic of this PR is performance New endpoint - pr_agent:A new endpoint was added in this PR SQL query - pr_agent:A new SQL query was added in this PR Dockerfile changes - pr_agent:The PR contains changes in the Dockerfile ... The list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases. Note that Labels are not mutually exclusive, so you can add multiple label categories. Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.

Utilizing extra instructions The describe tool can be configured with extra instructions, to guide the model to a feedback tailored to the needs of your project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Notice that the general structure of the description is fixed, and cannot be changed. Extra instructions can change the content or style of each sub-section of the PR description. Examples for extra instructions: [pr_description] extra_instructions=""" - The PR title should be in the format: '<PR type>: <title>' - The title should be short and concise (up to 10 words) - ... """ Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

More PR-Agent commands To invoke the PR-Agent, add a comment using one of the following commands: /review: Request a review of your Pull Request. /describe: Update the PR title and description based on the contents of the PR. /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback. /ask <QUESTION>: Ask a question about the PR. /update_changelog: Update the changelog based on the PR's contents. /add_docs 💎: Generate docstring for new components introduced in the PR. /generate_labels 💎: Generate labels for the PR based on the PR's contents. /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component. See the tools guide for more details. To list the possible configuration parameters, add a /config comment.

See the describe usage page for a comprehensive guide on using this tool.

[codiumai-pr-agent-free]

PR Description updated to latest commit (bfae917)

[codiumai-pr-agent-free]

PR Analysis

• 🎯 Main theme: This PR includes several bug fixes and enhancements related to handling of software bill of materials (SBOM) and Kubernetes containers.
• 📝 PR summary: The PR introduces changes to handle cases where the type is not set in the unpackSrcMetadata function, replaces the usage of instanceidhandler with helpersv1 for accessing various metadata keys, adds support for init containers, updates the required fields for several schemas, and updates the version of the kubescape/k8s-interface package.
• 📌 Type of PR: Bug fix
  Enhancement
• 🧪 Relevant tests added: No
• ⏱️ Estimated effort to review [1-5]: 3, because the PR involves changes in multiple files and introduces new logic for handling init containers and updating metadata keys. However, the changes are straightforward and well-explained.
• 🔒 Security concerns: No security concerns found

PR Feedback

💡 General suggestions: The PR seems to be well-structured and the changes are well-explained. However, it would be beneficial to include tests to verify the new changes, especially the handling of init containers and the updated metadata keys.

🤖 Code feedback:

---

relevant file	pkg/cleanup/cleanup.go
suggestion	Consider using constants for the repeated annotation keys like helpersv1.InstanceIDMetadataKey, helpersv1.ImageIDMetadataKey, etc. This can help avoid potential typos and make the code more maintainable. [medium]
relevant line	instanceId, ok := metadata.Annotations[helpersv1.InstanceIDMetadataKey]

---

relevant file	pkg/cleanup/discovery.go
suggestion	The logic for handling regular and init containers seems to be duplicated. Consider refactoring this into a separate function that can handle both cases to reduce code duplication. [important]
relevant line	initC, ok := workloadinterface.InspectMap(workload.Object, append(workloadinterface.PodSpec(workload.GetKind()), "initContainers")...)

---

relevant file	go.mod
suggestion	It's good to see packages being updated. However, ensure that the new version of kubescape/k8s-interface is fully compatible with your project and doesn't introduce any breaking changes. [medium]
relevant line	github.com/kubescape/k8s-interface v0.0.158-0.20240117162237-b087cd69bcf1

---

---

✨ Usage guide:

---

Overview:
The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:

/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:

[pr_reviewer]
some_config1=...
some_config2=...

Utilizing extra instructions The review tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize. Examples for extra instructions: [pr_reviewer] # /review # extra_instructions=""" In the code feedback section, emphasize the following: - Does the code logic cover relevant edge cases? - Is the code logic clear and easy to understand? - Is the code logic efficient? ... """ Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

How to enable\disable automation When you first install PR-Agent app, the default mode for the review tool is: pr_commands = ["/review", ...] meaning the review tool will run automatically on every PR, with the default configuration. Edit this field to enable/disable the tool, or to change the used configurations

About the 'Code feedback' section The review tool provides several type of feedbacks, one of them is code suggestions. If you are interested only in the code suggestions, it is recommended to use the improve feature instead, since it dedicated only to code suggestions, and usually gives better results. Use the review tool if you want to get a more comprehensive feedback, which includes code suggestions as well.

Auto-labels The review tool can auto-generate two specific types of labels for a PR: a possible security issue label, that detects possible security issues (enable_review_labels_security flag) a Review effort [1-5]: x label, where x is the estimated effort to review the PR (enable_review_labels_effort flag)

Extra sub-tools The review tool provides a collection of possible feedbacks about a PR. It is recommended to review the possible options, and choose the ones relevant for your use case. Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example: require_score_review, require_soc2_review, enable_review_labels_effort, and more.

More PR-Agent commands To invoke the PR-Agent, add a comment using one of the following commands: /review: Request a review of your Pull Request. /describe: Update the PR title and description based on the contents of the PR. /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback. /ask <QUESTION>: Ask a question about the PR. /update_changelog: Update the changelog based on the PR's contents. /add_docs 💎: Generate docstring for new components introduced in the PR. /generate_labels 💎: Generate labels for the PR based on the PR's contents. /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component. See the tools guide for more details. To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.

[github-actions]

Summary:

• License scan: failure
• Credentials scan: success
• Vulnerabilities scan: failure
• Unit test: success
• Go linting: success