Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MTV-1880] Move 'Plan name' field to step 1 of create migration plan wizard #1436

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jpuzz0
Copy link
Contributor

@jpuzz0 jpuzz0 commented Jan 17, 2025

📝 Links

MTV-1880
Design JIRA: https://issues.redhat.com/browse/HPUX-259

📝 Description

Moves "Plan name" form field of the create migration plan wizard to step 1 and enforces user to enter a value before proceeding to step 2.

Also, when creating from a provider's details page within the "Virtual machines" tab, clicking "Create migration plan" navigates users to step 1 (where a plan name must be entered) instead of step 2.

🎥 Demo

From list page:
https://github.com/user-attachments/assets/f8383824-34d2-45c6-91c8-7c071edbc9ab

From provider details page:
https://github.com/user-attachments/assets/3e1bea8f-4ee9-4db4-93b5-6471497cfeec

📝 CC:

@mmenestr

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.20%. Comparing base (13484d0) to head (6aee340).
Report is 184 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1436      +/-   ##
==========================================
- Coverage   36.81%   36.20%   -0.62%     
==========================================
  Files         158      159       +1     
  Lines        2548     2580      +32     
  Branches      599      602       +3     
==========================================
- Hits          938      934       -4     
- Misses       1428     1631     +203     
+ Partials      182       15     -167     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sgratch sgratch added the enhancement Categorizes issue or PR as related to a new feature. label Jan 17, 2025
@@ -59,6 +58,11 @@ export const PlanCreatePage: React.FC<{ namespace: string }> = ({ namespace }) =
});
useSaveEffect(state, dispatch);

const isFirstStepValid =
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can u please create a func in a util file for that?

@sgratch
Copy link
Collaborator

sgratch commented Jan 20, 2025

@mmenestr @jpuzz0
A concern regarding this design of always navigating to Wizard's step 1 (will add this to the Jira ticket as well):
If the user selected few VMs from different pages within the provider's VMs list, then in previous implementation he was navigated to Wizard's step 2 where the Selected VMs number field is displayed. If the wanted to change vms selection, he had to go back to step 1 and navigate to the relevant VM's page for changing.

Now in the new design, the user is navigated directly to step 1, where he can't even see that his selections were applied (if done on page > 1) and no Selected VMs field is shown

So either we need to move the Selected VMs number field to step 1 as well, or navigate the user to the 1st VMs page where VMs are pre--selected.
WDYT?

@metalice
Copy link
Collaborator

@mmenestr @jpuzz0 A concern regarding this design of always navigating to Wizard's step 1 (will add this to the Jira ticket as well): If the user selected few VMs from different pages within the provider's VMs list, then in previous implementation he was navigated to Wizard's step 2 where the Selected VMs number field is displayed. If the wanted to change vms selection, he had to go back to step 1 and navigate to the relevant VM's page for changing.

Now in the new design, the user is navigated directly to step 1, where he can't even see that his selections were applied (if done on page > 1) and no Selected VMs field is shown

So either we need to move the Selected VMs number field to step 1 as well, or navigate the user to the 1st VMs page where VMs are pre--selected. WDYT?

If the number in question of total VM is important to display to user I would go and move it to the description of the action.
Which means, Create Plan button will have a description below with the {vmsList.length}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants