-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MTV-1880] Move 'Plan name' field to step 1 of create migration plan wizard #1436
base: main
Are you sure you want to change the base?
Conversation
…wizard Signed-off-by: Jeff Puzzo <[email protected]>
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1436 +/- ##
==========================================
- Coverage 36.81% 36.20% -0.62%
==========================================
Files 158 159 +1
Lines 2548 2580 +32
Branches 599 602 +3
==========================================
- Hits 938 934 -4
- Misses 1428 1631 +203
+ Partials 182 15 -167 ☔ View full report in Codecov by Sentry. |
@@ -59,6 +58,11 @@ export const PlanCreatePage: React.FC<{ namespace: string }> = ({ namespace }) = | |||
}); | |||
useSaveEffect(state, dispatch); | |||
|
|||
const isFirstStepValid = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can u please create a func in a util file for that?
@mmenestr @jpuzz0 Now in the new design, the user is navigated directly to step 1, where he can't even see that his selections were applied (if done on page > 1) and no So either we need to move the |
If the number in question of total VM is important to display to user I would go and move it to the description of the action. |
📝 Links
MTV-1880
Design JIRA: https://issues.redhat.com/browse/HPUX-259
📝 Description
Moves "Plan name" form field of the create migration plan wizard to step 1 and enforces user to enter a value before proceeding to step 2.
Also, when creating from a provider's details page within the "Virtual machines" tab, clicking "Create migration plan" navigates users to step 1 (where a plan name must be entered) instead of step 2.
🎥 Demo
From list page:
https://github.com/user-attachments/assets/f8383824-34d2-45c6-91c8-7c071edbc9ab
From provider details page:
https://github.com/user-attachments/assets/3e1bea8f-4ee9-4db4-93b5-6471497cfeec
📝 CC:
@mmenestr