Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cni): support bound service account token by reloading periodically (backport of #12592) #12625

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

jijiechen
Copy link
Member

Motivation

Manual backport of #12592 to release-2.7

Implementation information

Supporting documentation

Fix #XX

…ly (kumahq#12592)

## Motivation

this should solve kumahq#12567 as a
simplified implementation.

Bart will come up with a more complete version based on his upcoming
refatoring.

## Implementation information

Setup a ticker and sync service account token into kubeconfig file
periodically

## Supporting documentation

<!-- Is there a MADR? An Issue? A related PR? -->

the official client-go SDK re-reads the token once a minute:

kubernetes/client-go#1255

> that method initiates a background process that rereads the token file
once a minute.

<!--
> Changelog: skip
-->
<!--
Uncomment the above section to explicitly set a [`> Changelog:` entry
here](https://github.com/kumahq/kuma/blob/master/CONTRIBUTING.md#submitting-a-patch)?
-->

Signed-off-by: Jay Chen <[email protected]>
@jijiechen jijiechen requested a review from a team as a code owner January 21, 2025 03:48
Copy link
Contributor

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

@Icarus9913 Icarus9913 changed the title fix(cni): support bound service account token by reloading periodically fix(cni): support bound service account token by reloading periodically (backport of #12592) Jan 21, 2025
@jijiechen jijiechen merged commit c5530fe into kumahq:release-2.7 Jan 21, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants