Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): fix the flaky test in the gateway scenario #12633

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

jijiechen
Copy link
Member

Motivation

Trying to fix the flaky test here: https://github.com/kumahq/kuma/actions/runs/12880363478/job/35911983525#step:12:11928

Implementation information

Wait for readiness of the test-server-mlbs app before using it.

Supporting documentation

Fix #XX

@jijiechen jijiechen requested a review from a team as a code owner January 21, 2025 09:16
@jijiechen jijiechen force-pushed the fix-gateway-e2e-release-28 branch from 00b2cfe to 4a95e72 Compare January 21, 2025 09:17
Copy link
Contributor

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

@jijiechen jijiechen requested review from Icarus9913 and bartsmykla and removed request for lukidzi January 21, 2025 09:31
Signed-off-by: Jay Chen <[email protected]>
@jijiechen jijiechen enabled auto-merge (squash) January 21, 2025 09:56
@Icarus9913 Icarus9913 changed the title fix(e2e): fix the flaky test in the gateway scenario test(e2e): fix the flaky test in the gateway scenario Jan 21, 2025
@jijiechen jijiechen merged commit 110ab37 into kumahq:release-2.8 Jan 21, 2025
16 checks passed
jijiechen added a commit that referenced this pull request Jan 21, 2025
## Motivation

Manual backport of PR #12633

Trying to fix the flaky test here:
https://github.com/kumahq/kuma/actions/runs/12880363478/job/35911983525#step:12:11928

## Implementation information

Wait for readiness of the `test-server-mlbs` app before using it.


> Changelog: skip

---------

Signed-off-by: Jay Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants