v0.8.0: Added 21 new UI prefabs and improved some existing ones #15
Conversation
WalkthroughThe pull request introduces several updates across multiple configuration and code files. The Changes
Possibly related PRs
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (7)
.gitignore (1)
205-205: Consider using a more specific pattern for debug logs.The current pattern
debug.log*might be too broad and could accidentally ignore important files.Consider using a more specific pattern:
-debug.log* +[Dd]ebug.log +[Dd]ebug.log.*Packages/black.kit.vrcui/Editor/Concreted/ButtonToggleEditor.cs (1)
27-28: Consider caching serialized property lookupThe
FindPropertycall could be moved to the constructor to avoid repeated lookups during every GUI update.Apply this diff to cache the property:
+ private SerializedProperty togglesProperty; + + public ButtonToggleEditor() : base(L10n.Tr(T.DETAIL_BUTTON_TOGGLE)) + { + togglesProperty = serializedObject.FindProperty(ButtonToggle.NAME_TOGGLES); + } public override void OnInspectorGUI() { // ... existing code ... - var arrayProp = serializedObject.FindProperty(ButtonToggle.NAME_TOGGLES); - toggle.group.CompleteToggles(arrayProp); + toggle.group.CompleteToggles(togglesProperty);Packages/black.kit.vrcui/Examples/Scripts/StatusCatalog.cs (1)
30-30: Simplify boolean expressionThe double negation (
!!) is an unusual syntax that could be simplified.Apply this diff to improve readability:
- protected override bool ValidateInspector() => !!progress; + protected override bool ValidateInspector() => progress != null;Packages/black.kit.vrcui/Editor/en.po (1)
8-13: LGTM with minor formatting suggestions.The translations are clear and descriptive. Consider these minor improvements for consistency:
- "FPS" could be expanded to "Frames Per Second (FPS)" for better clarity
- Consider adding HTML formatting tags for technical terms like "TextMeshPro" to match the style of other entries (e.g.,
<b>TextMeshPro</b>)Also applies to: 20-22
Packages/black.kit.vrcui/Runtime/Animations/ButtonTab/ButtonTabBody.controller (1)
187-187: Consider adjusting transition durations for smoother animations.The current transition duration of 0.05 seconds might be too quick for smooth visual feedback. Consider testing with slightly longer durations (e.g., 0.1-0.2 seconds) if the animations appear too abrupt.
Also applies to: 20-20
Packages/black.kit.vrcui/Runtime/Animations/ButtonTab/ButtonToggleBody.controller (2)
3-27: Consider optimizing state transitionsThe current transition configuration might benefit from these improvements:
- Disable self-transitions to prevent animation stuttering when the same state is triggered multiple times
- Consider making transition duration configurable via parameters for more flexibility
Apply this change to each transition:
m_TransitionDuration: 0.05 m_TransitionOffset: 0 m_ExitTime: 1 m_HasExitTime: 0 m_HasFixedDuration: 1 m_InterruptionSource: 0 m_OrderedInterruption: 1 - m_CanTransitionToSelf: 1 + m_CanTransitionToSelf: 0Also applies to: 140-164, 231-255
165-204: Standardize parameter naming conventionThe parameter "UnSelected" uses inconsistent capitalization compared to other parameters.
Consider renaming it to maintain consistency:
- Current: "Neutral", "UnSelected", "Selected"
- Suggested: "Neutral", "Unselected", "Selected"
m_AnimatorParameters: - m_Name: Neutral m_Type: 9 m_DefaultFloat: 0 m_DefaultInt: 0 m_DefaultBool: 0 m_Controller: {fileID: 0} - - m_Name: UnSelected + - m_Name: Unselected m_Type: 9 m_DefaultFloat: 0 m_DefaultInt: 0 m_DefaultBool: 0 m_Controller: {fileID: 0}
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
⛔ Files ignored due to path filters (79)
Assets/TextMesh Pro/Fonts/Dosis-Regular - OFL.txtis excluded by!Assets/TextMesh Pro/**/*Assets/TextMesh Pro/Fonts/Dosis-Regular - OFL.txt.metais excluded by!Assets/TextMesh Pro/**/*Assets/TextMesh Pro/Fonts/Dosis-Regular.ttfis excluded by!**/*.ttf,!Assets/TextMesh Pro/**/*Assets/TextMesh Pro/Fonts/Dosis-Regular.ttf.metais excluded by!Assets/TextMesh Pro/**/*Assets/TextMesh Pro/Resources/Fonts & Materials/Dosis-Regular SDF - Drop Shadow.matis excluded by!**/*.mat,!Assets/TextMesh Pro/**/*Assets/TextMesh Pro/Resources/Fonts & Materials/Dosis-Regular SDF - Drop Shadow.mat.metais excluded by!Assets/TextMesh Pro/**/*Assets/TextMesh Pro/Resources/Fonts & Materials/Dosis-Regular SDF - Fallback.assetis excluded by!**/*.asset,!Assets/TextMesh Pro/**/*Assets/TextMesh Pro/Resources/Fonts & Materials/Dosis-Regular SDF - Fallback.asset.metais excluded by!Assets/TextMesh Pro/**/*Assets/TextMesh Pro/Resources/Fonts & Materials/Dosis-Regular SDF - Outline.matis excluded by!**/*.mat,!Assets/TextMesh Pro/**/*Assets/TextMesh Pro/Resources/Fonts & Materials/Dosis-Regular SDF - Outline.mat.metais excluded by!Assets/TextMesh Pro/**/*Assets/TextMesh Pro/Resources/Fonts & Materials/Dosis-Regular SDF.assetis excluded by!**/*.asset,!Assets/TextMesh Pro/**/*Assets/TextMesh Pro/Resources/Fonts & Materials/Dosis-Regular SDF.asset.metais excluded by!Assets/TextMesh Pro/**/*Packages/black.kit.vrcui/Examples/Images/Icon-example.pngis excluded by!**/*.pngPackages/black.kit.vrcui/Examples/Prefabs/Atoms/ButtonTabCatalog.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Atoms/LargeTabItemsCatalog.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Atoms/ScrollbarsCatalog.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Atoms/SlidersCatalog.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Atoms/TogglesCatalog.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Common/Credit.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Common/MainMenuCategoryCatalogBase.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Common/QuickMenuCatalogBase.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Molecules/BasicCardsCatalog.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Molecules/ButtonTogglesCatalog.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Molecules/CompositedButtonsCatalog.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Molecules/CompositedCards1Catalog.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Molecules/CompositedCards2Catalog.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Molecules/CompositedCategoryItemsCatalog.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Molecules/CompositedTogglesCatalog.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Molecules/HeroCatalog.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Molecules/ListsCatalog.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Molecules/ModalBaseCatalog.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Molecules/ScrollRectsCatalog.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Molecules/StatusToggleCatalog.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Molecules/SummaryCatalog.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Molecules/TextSlideSwitchCatalog.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Molecules/ThickScrollbarsCatalog.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Molecules/WingBaseCatalog.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Organisms/AlertModalCatalog.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Organisms/BottomAlertModalCatalog.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Organisms/BottomConfirmModalCatalog.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Organisms/CategoryMenuCatalog1.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Organisms/CategoryMenuCatalog2.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Organisms/ConfirmModalCatalog.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Organisms/QLaunchPadMenuCatalog.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Organisms/StatusCatalog.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Scenes/Catalogs.unityis excluded by!**/*.unityPackages/black.kit.vrcui/Examples/Scripts/StatusCatalog.assetis excluded by!**/*.assetPackages/black.kit.vrcui/Runtime/Prefabs/Atoms/Nav/ButtonTab.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Atoms/Nav/CategoryItem.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Molecules/ButtonTab/ButtonToggle.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Molecules/ButtonTab/SelectButton.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Molecules/ButtonTab/SlideSwitchTab.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Molecules/Buttons/IconWithCaptionButton.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Molecules/Buttons/QuickButton.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Molecules/Cards/GroupCard.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Molecules/Cards/LocationCard.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Molecules/Cards/WorldCard.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Molecules/Cards/WorldCardWithTab.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Molecules/Nav/MenuCategoryBase.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Molecules/QuickMenu/QuickMenu.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Organisms/Category/AvatarsMenu.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Organisms/Category/GroupsMenu.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Organisms/Category/HelpAndInfoMenu.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Organisms/Category/MarketplaceMenu.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Organisms/Category/NotificationsMenu.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Organisms/Category/SettingsMenu.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Organisms/Category/SocialMenu.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Organisms/Category/VRChatPlusMenu.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Organisms/Modal/AlertModal.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Organisms/Modal/BottomAlertModal.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Organisms/Modal/BottomConfirmModal.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Organisms/Modal/ConfirmModal.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Organisms/QuickMenu/QLaunchPadMenu.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Organisms/Status/Fps.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Organisms/Status/Progress.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Scripts/ButtonToggle.assetis excluded by!**/*.assetPackages/black.kit.vrcui/Runtime/Scripts/Fps.assetis excluded by!**/*.assetPackages/black.kit.vrcui/Runtime/Scripts/Progress.assetis excluded by!**/*.assetProjectSettings/ProjectSettings.assetis excluded by!**/*.asset,!ProjectSettings/**/*
📒 Files selected for processing (47)
.coderabbit.yaml(1 hunks).gitattributes(1 hunks).gitconfig(1 hunks).gitignore(1 hunks).tool-versions(1 hunks).vscode/settings.json(1 hunks)Packages/black.kit.vrcui/Editor/Concreted/ButtonToggleEditor.cs(1 hunks)Packages/black.kit.vrcui/Editor/Concreted/ButtonToggleEditor.cs.meta(1 hunks)Packages/black.kit.vrcui/Editor/Concreted/FpsEditor.cs(1 hunks)Packages/black.kit.vrcui/Editor/Concreted/FpsEditor.cs.meta(1 hunks)Packages/black.kit.vrcui/Editor/Concreted/ProgressEditor.cs(1 hunks)Packages/black.kit.vrcui/Editor/Concreted/ProgressEditor.cs.meta(1 hunks)Packages/black.kit.vrcui/Editor/T.cs(1 hunks)Packages/black.kit.vrcui/Editor/en.po(1 hunks)Packages/black.kit.vrcui/Editor/ja.po(1 hunks)Packages/black.kit.vrcui/Examples/Images/Icon-example.png.meta(1 hunks)Packages/black.kit.vrcui/Examples/Prefabs/Atoms/ButtonTabCatalog.prefab.meta(1 hunks)Packages/black.kit.vrcui/Examples/Prefabs/Common/MainMenuCategoryCatalogBase.prefab.meta(1 hunks)Packages/black.kit.vrcui/Examples/Prefabs/Common/QuickMenuCatalogBase.prefab.meta(1 hunks)Packages/black.kit.vrcui/Examples/Prefabs/Molecules/ButtonTogglesCatalog.prefab.meta(1 hunks)Packages/black.kit.vrcui/Examples/Prefabs/Organisms.meta(1 hunks)Packages/black.kit.vrcui/Examples/Prefabs/Organisms/AlertModalCatalog.prefab.meta(1 hunks)Packages/black.kit.vrcui/Examples/Prefabs/Organisms/BottomAlertModalCatalog.prefab.meta(1 hunks)Packages/black.kit.vrcui/Examples/Prefabs/Organisms/BottomConfirmModalCatalog.prefab.meta(1 hunks)Packages/black.kit.vrcui/Examples/Prefabs/Organisms/CategoryMenuCatalog1.prefab.meta(1 hunks)Packages/black.kit.vrcui/Examples/Prefabs/Organisms/CategoryMenuCatalog2.prefab.meta(1 hunks)Packages/black.kit.vrcui/Examples/Prefabs/Organisms/ConfirmModalCatalog.prefab.meta(1 hunks)Packages/black.kit.vrcui/Examples/Prefabs/Organisms/QLaunchPadMenuCatalog.prefab.meta(1 hunks)Packages/black.kit.vrcui/Examples/Prefabs/Organisms/StatusCatalog.prefab.meta(1 hunks)Packages/black.kit.vrcui/Examples/Scripts/StatusCatalog.asset.meta(1 hunks)Packages/black.kit.vrcui/Examples/Scripts/StatusCatalog.cs(1 hunks)Packages/black.kit.vrcui/Examples/Scripts/StatusCatalog.cs.meta(1 hunks)Packages/black.kit.vrcui/Runtime/Animations/ButtonTab.meta(1 hunks)Packages/black.kit.vrcui/Runtime/Animations/ButtonTab/ButtonTab.controller(1 hunks)Packages/black.kit.vrcui/Runtime/Animations/ButtonTab/ButtonTab.controller.meta(1 hunks)Packages/black.kit.vrcui/Runtime/Animations/ButtonTab/ButtonTabBody.controller(1 hunks)Packages/black.kit.vrcui/Runtime/Animations/ButtonTab/ButtonTabBody.controller.meta(1 hunks)Packages/black.kit.vrcui/Runtime/Animations/ButtonTab/ButtonTabIdle.anim(1 hunks)Packages/black.kit.vrcui/Runtime/Animations/ButtonTab/ButtonTabIdle.anim.meta(1 hunks)Packages/black.kit.vrcui/Runtime/Animations/ButtonTab/ButtonTabNeutral.anim(1 hunks)Packages/black.kit.vrcui/Runtime/Animations/ButtonTab/ButtonTabNeutral.anim.meta(1 hunks)Packages/black.kit.vrcui/Runtime/Animations/ButtonTab/ButtonTabUnselected.anim(1 hunks)Packages/black.kit.vrcui/Runtime/Animations/ButtonTab/ButtonTabUnselected.anim.meta(1 hunks)Packages/black.kit.vrcui/Runtime/Animations/ButtonTab/ButtonToggle.controller(1 hunks)Packages/black.kit.vrcui/Runtime/Animations/ButtonTab/ButtonToggle.controller.meta(1 hunks)Packages/black.kit.vrcui/Runtime/Animations/ButtonTab/ButtonToggleBody.controller(1 hunks)Packages/black.kit.vrcui/Runtime/Animations/ButtonTab/ButtonToggleBody.controller.meta(1 hunks)
✅ Files skipped from review due to trivial changes (33)
- .gitconfig
- Packages/black.kit.vrcui/Runtime/Animations/ButtonTab/ButtonTabBody.controller.meta
- Packages/black.kit.vrcui/Examples/Scripts/StatusCatalog.asset.meta
- Packages/black.kit.vrcui/Examples/Prefabs/Atoms/ButtonTabCatalog.prefab.meta
- Packages/black.kit.vrcui/Examples/Prefabs/Organisms/BottomConfirmModalCatalog.prefab.meta
- Packages/black.kit.vrcui/Examples/Prefabs/Organisms/QLaunchPadMenuCatalog.prefab.meta
- Packages/black.kit.vrcui/Runtime/Animations/ButtonTab/ButtonToggle.controller.meta
- Packages/black.kit.vrcui/Examples/Prefabs/Organisms.meta
- Packages/black.kit.vrcui/Runtime/Animations/ButtonTab/ButtonTabUnselected.anim.meta
- Packages/black.kit.vrcui/Runtime/Animations/ButtonTab/ButtonTabNeutral.anim.meta
- Packages/black.kit.vrcui/Examples/Prefabs/Organisms/CategoryMenuCatalog2.prefab.meta
- Packages/black.kit.vrcui/Examples/Prefabs/Organisms/BottomAlertModalCatalog.prefab.meta
- Packages/black.kit.vrcui/Runtime/Animations/ButtonTab/ButtonTabIdle.anim.meta
- Packages/black.kit.vrcui/Examples/Scripts/StatusCatalog.cs.meta
- Packages/black.kit.vrcui/Runtime/Animations/ButtonTab/ButtonToggleBody.controller.meta
- Packages/black.kit.vrcui/Examples/Prefabs/Molecules/ButtonTogglesCatalog.prefab.meta
- Packages/black.kit.vrcui/Editor/Concreted/ProgressEditor.cs.meta
- Packages/black.kit.vrcui/Examples/Prefabs/Organisms/StatusCatalog.prefab.meta
- Packages/black.kit.vrcui/Runtime/Animations/ButtonTab/ButtonTab.controller.meta
- Packages/black.kit.vrcui/Editor/Concreted/FpsEditor.cs.meta
- .gitattributes
- Packages/black.kit.vrcui/Runtime/Animations/ButtonTab/ButtonTabNeutral.anim
- Packages/black.kit.vrcui/Runtime/Animations/ButtonTab.meta
- Packages/black.kit.vrcui/Examples/Images/Icon-example.png.meta
- Packages/black.kit.vrcui/Examples/Prefabs/Organisms/CategoryMenuCatalog1.prefab.meta
- .tool-versions
- Packages/black.kit.vrcui/Runtime/Animations/ButtonTab/ButtonTabIdle.anim
- Packages/black.kit.vrcui/Runtime/Animations/ButtonTab/ButtonTabUnselected.anim
- Packages/black.kit.vrcui/Examples/Prefabs/Common/QuickMenuCatalogBase.prefab.meta
- Packages/black.kit.vrcui/Examples/Prefabs/Organisms/ConfirmModalCatalog.prefab.meta
- Packages/black.kit.vrcui/Examples/Prefabs/Organisms/AlertModalCatalog.prefab.meta
- Packages/black.kit.vrcui/Examples/Prefabs/Common/MainMenuCategoryCatalogBase.prefab.meta
- Packages/black.kit.vrcui/Editor/Concreted/ButtonToggleEditor.cs.meta
🔇 Additional comments (36)
.coderabbit.yaml (1)
9-11: LGTM! Verify the completeness of exclusion patterns.
The refined path filters provide better granularity by excluding specific third-party directories instead of broad exclusions. This allows for better code review coverage while still excluding vendor files.
Let's verify if these patterns cover all necessary third-party directories:
Also applies to: 13-13
✅ Verification successful
The exclusion patterns are complete and accurate
The verification confirms that the current exclusion patterns (TextMesh Pro, UdonSharp, and XR) correctly identify all the major third-party directories in the Assets folder. These directories contain typical vendor files (.asset files) and follow standard Unity asset structures. No additional third-party directories were found that would require exclusion.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for any additional third-party directories that might need exclusion
# Look for potential vendor directories in Assets that aren't currently excluded
fd --type d --max-depth 2 '^(TextMesh Pro|UdonSharp|XR)' Assets/
Length of output: 116
Script:
#!/bin/bash
# Let's check for other potential third-party or vendor-like directories in Assets
fd --type d --max-depth 2 . Assets/ | grep -iE '(sdk|pro|plugin|vendor|package|third|external)'
# Also check if there are any large files or binary files in these directories that confirm they are vendor files
find Assets/TextMesh\ Pro Assets/UdonSharp Assets/XR -type f -name "*.*" | grep -iE '\.(dll|bundle|so|dylib|jar|aar|framework|asset|unitypackage)$'
Length of output: 1516
.gitignore (3)
198-200: LGTM! TextMesh Pro exclusions added.
Appropriate exclusion of TextMesh Pro generated files.
202-203: LGTM! UdonSharp build artifacts excluded.
Correctly excludes UdonSharp's generated files and build artifacts.
208-209: LGTM! VRChat SDK exclusions added.
Appropriate exclusion of VRChat SDK's client simulation storage.
.vscode/settings.json (1)
164-167: Verify the accessibility of the new schema URL.
The schema URL has been updated to use Google Cloud Storage, which should provide better availability.
Let's verify the schema accessibility:
✅ Verification successful
Schema URL is accessible and properly configured
The new schema URL is working correctly with proper JSON content type and caching headers. The schema file is hosted on Google Cloud Storage with standard availability and is publicly accessible.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the new schema URL is accessible
curl -I https://storage.googleapis.com/coderabbit_public_assets/schema.v2.json
Length of output: 1065
Packages/black.kit.vrcui/Runtime/Animations/ButtonTab/ButtonTab.controller (11)
4-28: Animator State 'Normal' Configuration
The 'Normal' animator state is correctly defined with the appropriate settings and linked to the 'Normal' animation clip. All state parameters such as speed, cycle offset, and motion are properly set.
30-54: Transition to 'Selected' State is Properly Configured
The transition from the 'Normal' state to the 'Selected' state is correctly set up with the condition based on the 'Selected' parameter. Transition duration and other settings are appropriately configured.
55-407: Animation Clip 'Highlighted' Parameters are Correct
The 'Highlighted' animation clip is well-defined with accurate curve data for UI elements such as icon opacity, label opacity, position, and background color. The animation curves ensure smooth transitions for the highlighted state.
412-437: Animator State 'Selected' Configuration
The 'Selected' animator state is properly defined and linked to the 'Selected' animation clip. All necessary parameters are correctly set.
438-793: Animation Clips 'Disabled' and 'Selected' Correctly Defined
The 'Disabled' and 'Selected' animation clips have appropriate curve definitions for color and position, ensuring correct visual representation of the button in different states.
1152-1177: Animator State 'Disabled' Configuration
The 'Disabled' state is correctly configured with proper parameters and linked to the 'Disabled' animation clip. This ensures the UI reflects the disabled state accurately.
1178-1203: Animator State 'Pressed' Configuration
The 'Pressed' state is properly set up and associated with the 'Pressed' animation clip. Parameters like speed and cycle offset are correctly assigned.
1204-1560: Animation Clip 'Pressed' Parameters are Accurate
The animation clip for the 'Pressed' state contains the correct curves for animating UI elements during the pressed interaction, ensuring responsive feedback.
1561-1599: Animator Parameters Defined Appropriately
All animator parameters ('Normal', 'Highlighted', 'Pressed', 'Selected', 'Disabled') are correctly declared, enabling state transitions based on user interactions.
1613-1687: Animator State Transitions Configured Correctly
Transitions between states are properly set up with the correct conditions and transition durations, ensuring smooth state changes in response to parameter updates.
1714-1752: Animator State Machine Structure is Proper
The base layer state machine includes all necessary states and transitions. The default state is set to 'Normal', which is appropriate for initialization.
Packages/black.kit.vrcui/Runtime/Animations/ButtonTab/ButtonToggle.controller (9)
4-28: Animator State 'Normal' Configuration
The 'Normal' animator state for 'ButtonToggle' is correctly defined and linked to its corresponding animation clip. State parameters are accurately set.
30-54: Transition to 'Selected' State is Properly Configured
The transition condition to the 'Selected' state is correctly based on the 'Selected' parameter, with appropriate transition duration and offset.
55-560: Animation Clip 'Highlighted' Correctly Defined
The 'Highlighted' animation clip includes precise curve definitions for UI element properties, ensuring visual consistency when the button is highlighted.
565-590: Animator State 'Selected' Configuration
The 'Selected' state is properly configured with the correct motion reference, facilitating accurate representation of the selected state.
591-1100: Animation Clip 'Disabled' Parameters are Correct
The 'Disabled' animation clip is defined with appropriate curves, ensuring UI elements reflect the disabled state visually.
1637-1662: Animator State 'Pressed' Configuration
The 'Pressed' state is correctly set up and linked to the 'Pressed' animation clip, with all necessary state settings defined.
1663-2172: Animation Clip 'Pressed' Accurately Configured
The 'Pressed' animation clip contains accurate curve data for UI element animations during the pressed interaction, providing immediate feedback to the user.
2173-2211: Animator Parameters Properly Declared
All required animator parameters are defined, allowing for state transitions based on user interactions with the 'ButtonToggle'.
2225-2898: Animator State Machine and Transitions Configured Correctly
The state machine structure and transitions are correctly implemented, ensuring seamless state changes in the 'ButtonToggle' component.
Packages/black.kit.vrcui/Editor/Concreted/FpsEditor.cs (2)
7-12: Constructor Implements Localization Correctly
The constructor of FpsEditor correctly initializes the base class with a localized string using L10n.Tr(T.DETAIL_FPS), ensuring the editor displays the appropriate localized detail text.
15-20: Override of OnInspectorGUI is Properly Implemented
The OnInspectorGUI method is correctly overridden to include custom drawing methods DrawBanner() and DrawDetails() before calling the base implementation, enhancing the inspector GUI for the Fps component.
Packages/black.kit.vrcui/Editor/Concreted/ProgressEditor.cs (2)
7-12: Constructor Utilizes Localization Appropriately
The ProgressEditor constructor correctly passes a localized string L10n.Tr(T.DETAIL_PROGRESS) to the base class, ensuring proper localization support in the editor.
15-20: OnInspectorGUI Method is Correctly Overridden
The override of OnInspectorGUI effectively customizes the inspector by invoking DrawBanner() and DrawDetails() before the base method, providing an enhanced user experience for the Progress component.
Packages/black.kit.vrcui/Editor/ja.po (1)
8-22: LGTM! Clear and well-structured translations
The new message entries provide clear and accurate Japanese translations that align well with the component functionalities. The translations maintain consistency with the existing style and format.
Packages/black.kit.vrcui/Editor/T.cs (1)
6-7: LGTM! Constants follow consistent naming and implementation patterns.
The new localization constants are well-structured and use the nameof operator consistently, which provides compile-time safety for localization keys.
Also applies to: 10-10
Packages/black.kit.vrcui/Runtime/Animations/ButtonTab/ButtonTabBody.controller (2)
28-57: LGTM! Well-structured state machine with clear transitions.
The animator controller has a clean layout with proper state positioning and logical transitions. The base layer is well-organized with appropriate entry/exit points.
78-78: Verify the referenced animation clips.
Please ensure the following animation clips exist and contain appropriate animations:
- guid: 818197309d73e9b4092cb4d404477821 (ButtonTabUnselected)
- guid: 2b09d89a41e18204181b508ef0acff8b (ButtonTabNeutral)
- guid: 6a5e557315fc22a4e885e81ed155e323 (ButtonTabIdle)
Also applies to: 104-104, 164-164
✅ Verification successful
Animation clips are present and properly referenced
The search results confirm that all the required animation clips exist in the project:
- ButtonTabUnselected (818197309d73e9b4092cb4d404477821)
- ButtonTabNeutral (2b09d89a41e18204181b508ef0acff8b)
- ButtonTabIdle (6a5e557315fc22a4e885e81ed155e323)
All files are located in Packages/black.kit.vrcui/Runtime/Animations/ButtonTab/ directory.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify that the referenced animation clips exist in the project
# Search for the animation clip GUIDs
echo "Searching for animation clips..."
fd -t f --full-path . | xargs grep -l "818197309d73e9b4092cb4d404477821\|2b09d89a41e18204181b508ef0acff8b\|6a5e557315fc22a4e885e81ed155e323"
Length of output: 14695
Packages/black.kit.vrcui/Runtime/Animations/ButtonTab/ButtonToggleBody.controller (3)
28-61: Well-organized state machine structure
The state machine is cleanly organized with:
- Logical state positioning for visual clarity
- Clear entry/exit points
- Appropriate default state selection
1-255: Verify edge case handling
Please ensure the following scenarios are tested:
- Rapid state changes (spam clicking)
- Interrupted transitions
- Initial state behavior on prefab instantiation
Would you like me to provide a test script that covers these scenarios?
62-139: Verify animation clip references
Please ensure all referenced animation clips exist and are properly configured:
- ButtonToggleIdle:
f1882743851625243abf9ff71448492f - ButtonToggleNeutral:
f5351a9430a7afd4ca6e6ce30d86bc0e - ButtonToggleSelected:
19ff43c615dc72144995fed8605ebda4 - ButtonToggleUnselected:
488c0b40ed25c1b449ec71e7d3bdfa5a
Also applies to: 205-230
✅ Verification successful
Based on the output, I can see that all four animation clips exist in the project at the correct locations:
- ButtonToggleIdle.anim.meta
- ButtonToggleNeutral.anim.meta
- ButtonToggleSelected.anim.meta
- ButtonToggleUnselected.anim.meta
All files are located in the Packages/black.kit.vrcui/Runtime/Animations/ButtonTab/ directory and their GUIDs match exactly with those referenced in the animator controller.
All animation clips are properly configured and present
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify that all referenced animation clips exist in the project
# Note: Animation clips in Unity are stored as .anim files
echo "Searching for animation clips..."
for guid in f1882743851625243abf9ff71448492f f5351a9430a7afd4ca6e6ce30d86bc0e 19ff43c615dc72144995fed8605ebda4 488c0b40ed25c1b449ec71e7d3bdfa5a; do
fd -e meta | xargs grep -l "$guid"
done
Length of output: 32079
| var toggle = TypedTarget.GetComponent<Toggle>(); | ||
| if (toggle.group) | ||
| { | ||
| var arrayProp = serializedObject.FindProperty(ButtonToggle.NAME_TOGGLES); | ||
| toggle.group.CompleteToggles(arrayProp); | ||
| } |
There was a problem hiding this comment.
Add null check for toggle component
The code assumes the Toggle component exists and directly accesses its group property without validation. This could cause NullReferenceException if the Toggle component is missing.
Apply this diff to add proper null checks:
- var toggle = TypedTarget.GetComponent<Toggle>();
- if (toggle.group)
+ var toggle = TypedTarget.GetComponent<Toggle>();
+ if (toggle != null && toggle.group != null)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| var toggle = TypedTarget.GetComponent<Toggle>(); | |
| if (toggle.group) | |
| { | |
| var arrayProp = serializedObject.FindProperty(ButtonToggle.NAME_TOGGLES); | |
| toggle.group.CompleteToggles(arrayProp); | |
| } | |
| var toggle = TypedTarget.GetComponent<Toggle>(); | |
| if (toggle != null && toggle.group != null) | |
| { | |
| var arrayProp = serializedObject.FindProperty(ButtonToggle.NAME_TOGGLES); | |
| toggle.group.CompleteToggles(arrayProp); | |
| } |
| var gap = Random.Range(0f, 0.5f); | ||
| progress.Value = (progress.Value + delta + gap) % progress.Limit; |
There was a problem hiding this comment.
Add bounds checking and null validation for progress updates
The code directly accesses the progress component without null validation and doesn't ensure the calculated value stays within valid bounds.
Apply this diff to add proper validation:
- var gap = Random.Range(0f, 0.5f);
- progress.Value = (progress.Value + delta + gap) % progress.Limit;
+ if (progress != null)
+ {
+ var gap = Random.Range(0f, 0.5f);
+ var newValue = (progress.Value + delta + gap) % progress.Limit;
+ progress.Value = Mathf.Clamp(newValue, 0f, progress.Limit);
+ }📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| var gap = Random.Range(0f, 0.5f); | |
| progress.Value = (progress.Value + delta + gap) % progress.Limit; | |
| if (progress != null) | |
| { | |
| var gap = Random.Range(0f, 0.5f); | |
| var newValue = (progress.Value + delta + gap) % progress.Limit; | |
| progress.Value = Mathf.Clamp(newValue, 0f, progress.Limit); | |
| } |
Overview
We added 21 new UI prefabs and improved some existing ones. We also updated the sample world to include the QvPen and improved some catalogs.
Features
Atoms/Nav/ButtonTabMolecules/ButtonTab/ButtonToggleMolecules/ButtonTab/SelectButtonMolecules/ButtonTab/SlideSwitchTabMolecules/Nav/MenuCategoryBaseMolecules/QuickMenu/QuickMenuOrganisms/Category/AvatarsMenuOrganisms/Category/GroupsMenuOrganisms/Category/HelpAndInfoMenuOrganisms/Category/MarketplaceMenuOrganisms/Category/NotificationsMenuOrganisms/Category/SettingsMenuOrganisms/Category/SocialMenuOrganisms/Category/VRChatPlusMenuOrganisms/Modal/AlertModalOrganisms/Modal/BottomAlertModalOrganisms/Modal/BottomConfirmModalOrganisms/Modal/ConfirmModalOrganisms/QuickMenu/QLaunchPadMenuOrganisms/Status/FpsOrganisms/Status/ProgressAtoms/Nav/ButtonTabAtoms/Nav/CategoryItemMolecules/Cards/GroupCardMolecules/Cards/LocationCardMolecules/Cards/WorldCardMolecules/Cards/WorldCardWithTabMolecules/Nav/GroupCategoryItemUpdates the sample world
Other updates
Updates for project environment
CI/CD
Summary by CodeRabbit
New Features
ButtonToggle,Fps, andProgresscomponents in the Unity Editor.Bug Fixes
Documentation
Chores