v0.9.0: Added the new UI prefabs #16
Conversation
- ! added the expandable icon to the icon with caption button. - removed the raycast target from the expandable icon from the expandable button. - improved the layout to the navigation icon button
- added the small-sized player card - moved the credit card prefab to the basic cards catalog - improved the layout to the cards with tab - fixed the bug that the interactive player card's bg-image wasn't interactive
- swapped some prefabs between the catalogs - removed the expandable icons.
WalkthroughThis pull request encompasses a series of minor updates across multiple files in a Unity project. The changes primarily involve workflow configuration adjustments in GitHub Actions files, updates to package dependencies, and the addition of new metadata files for prefabs and assets. The modifications focus on version updates, workflow formatting, and asset management within the project structure. Changes
Possibly related PRs
Suggested Labels
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Packages/black.kit.vrcui/Runtime/Animations/Button/IconWithCaptionButton.controller (1)
1788-1828: Consider normalizing z-positions across statesThe current z-position variations between states (-0.3 for Normal, -2.4 for Highlighted/Selected, 0 for others) might cause:
- Depth sorting issues due to large jumps
- Inconsistent UI layering
Consider using consistent z-positions across all states or smaller increments if depth separation is needed.
Also applies to: 513-553
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (20)
Packages/black.kit.vrcui/Examples/Prefabs/Molecules/BasicCardsCatalog.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Molecules/CompositedCards1Catalog.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Organisms/CategoryMenuCatalog1.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Organisms/CategoryMenuCatalog2.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Prefabs/Organisms/WingsRootMenuCatalog.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Examples/Scenes/Catalogs.unityis excluded by!**/*.unityPackages/black.kit.vrcui/Runtime/Prefabs/Molecules/Buttons/ExpandableButton.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Molecules/Buttons/IconWithCaptionButton.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Molecules/Buttons/NavigationIconButton.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Molecules/Cards/CompactPlayerCard.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Molecules/Cards/GroupCardWithTab.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Molecules/Cards/InteractivePlayerCard.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Molecules/Cards/PlayerCard.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Molecules/Cards/PurchaseCard.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Molecules/Cards/SocialCardWithTab.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Molecules/Cards/WorldCardWithTab.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Organisms/Category/AvatarsMenu.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Organisms/Category/SocialMenu.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Organisms/Mock/QuickMenu.prefabis excluded by!**/*.prefabPackages/black.kit.vrcui/Runtime/Prefabs/Organisms/Wings/WingsRootMenu.prefabis excluded by!**/*.prefab
📒 Files selected for processing (14)
.github/workflows/build-listing.yml(2 hunks).github/workflows/push.yml(2 hunks).github/workflows/release.yml(3 hunks)Packages/black.kit.vrcui/Examples/Prefabs/Organisms/WingsRootMenuCatalog.prefab.meta(1 hunks)Packages/black.kit.vrcui/Runtime/Animations/Button/IconWithCaptionButton.controller(1 hunks)Packages/black.kit.vrcui/Runtime/Animations/Button/IconWithCaptionButton.controller.meta(1 hunks)Packages/black.kit.vrcui/Runtime/Prefabs/Molecules/Cards/CompactPlayerCard.prefab.meta(1 hunks)Packages/black.kit.vrcui/Runtime/Prefabs/Organisms/Mock.meta(1 hunks)Packages/black.kit.vrcui/Runtime/Prefabs/Organisms/Mock/QuickMenu.prefab.meta(1 hunks)Packages/black.kit.vrcui/Runtime/Prefabs/Organisms/Wings.meta(1 hunks)Packages/black.kit.vrcui/Runtime/Prefabs/Organisms/Wings/WingsRootMenu.prefab.meta(1 hunks)Packages/black.kit.vrcui/package.json(2 hunks)Packages/vpm-manifest.json(2 hunks)cspell.config.yml(1 hunks)
✅ Files skipped from review due to trivial changes (7)
- Packages/black.kit.vrcui/Runtime/Prefabs/Organisms/Wings.meta
- Packages/black.kit.vrcui/Runtime/Prefabs/Organisms/Mock.meta
- Packages/black.kit.vrcui/Runtime/Animations/Button/IconWithCaptionButton.controller.meta
- Packages/black.kit.vrcui/Examples/Prefabs/Organisms/WingsRootMenuCatalog.prefab.meta
- Packages/black.kit.vrcui/Runtime/Prefabs/Molecules/Cards/CompactPlayerCard.prefab.meta
- Packages/black.kit.vrcui/Runtime/Prefabs/Organisms/Mock/QuickMenu.prefab.meta
- Packages/black.kit.vrcui/Runtime/Prefabs/Organisms/Wings/WingsRootMenu.prefab.meta
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/release.yml
14-14: shellcheck reported issue in this script: SC2086:info:2:32: Double quote to prevent globbing and word splitting
(shellcheck)
14-14: shellcheck reported issue in this script: SC2086:info:4:33: Double quote to prevent globbing and word splitting
(shellcheck)
🔇 Additional comments (14)
Packages/black.kit.vrcui/Runtime/Animations/Button/IconWithCaptionButton.controller (3)
19-27: Well-configured transition timing!The transition configuration is optimal for a responsive UI button:
- Quick 0.05s duration provides snappy feedback
- Fixed duration ensures consistent behavior
- Exit time of 1 prevents animation interruption
896-946: Well-structured state machine implementation!The animator controller follows UI best practices:
- Comprehensive coverage of UI states (Normal, Highlighted, Pressed, Selected, Disabled)
- Clear transition conditions
- Logical default state
70-154: Well-designed color transitions!The color animations demonstrate good UI/UX practices:
- Clear visual distinction between states
- Consistent opacity for enabled states
- Appropriate dimming for disabled state
cspell.config.yml (1)
18-18: LGTM! Appropriate addition to ignore pathsThe addition of "Assets/TextMesh Pro" to ignored paths is consistent with other Unity-related paths and will prevent unnecessary spell checking of TextMesh Pro asset files.
.github/workflows/push.yml (2)
42-42: LGTM! Improved cache key configurationThe cache key now includes hashes of both global.json and *.csproj files, which will ensure better cache invalidation when these critical files change.
49-49:⚠️ Potential issueFix shell script quoting to prevent globbing
The command needs proper quoting to prevent potential word splitting and globbing issues.
Apply this fix:
- run: '"${{ env.pathToCi }}/build.cmd" BuildRepoListing --root "${{ env.pathToCi }}" --list-publish-directory "$GITHUB_WORKSPACE/${{ env.listPublishDirectory }}" --current-package-name "${{ vars.PACKAGE_NAME }}"' + run: '"${{ env.pathToCi }}/build.cmd" BuildRepoListing --root "${{ env.pathToCi }}" --list-publish-directory "${GITHUB_WORKSPACE}/${listPublishDirectory}" --current-package-name "${PACKAGE_NAME}"'Likely invalid or redundant comment.
.github/workflows/build-listing.yml (1)
27-27: LGTM! Explicit permission declarationGood security practice to explicitly declare the pages:write permission needed for GitHub Pages deployment.
.github/workflows/release.yml (3)
29-31: LGTM! Well-scoped permissionsThe workflow correctly defines minimal required permissions (contents:write) for release operations.
Line range hint
51-58: LGTM! Robust version detectionThe version detection uses a comprehensive regex pattern that correctly handles semantic versioning, including build metadata.
77-83: Verify GPG signing environmentThe GPG signing step properly uses secrets, but consider verifying the GPG environment setup.
✅ Verification successful
GPG signing environment is properly configured ✅
The workflow has a complete and secure GPG setup using industry-standard practices:
- Proper key import via
crazy-max/ghaction-import-gpg@v6- Maximum trust level configuration
- Consistent use of secrets across signing operations
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify GPG configuration in the workflow # Test: Check if GPG signing is configured correctly in other workflows # Look for GPG signing configurations rg -l 'gpg.*sign|GPG_.*KEY|GPG_PASSPHRASE' .github/workflows/Length of output: 93
Script:
#!/bin/bash # Check for GPG setup steps in release.yml cat .github/workflows/release.ymlLength of output: 4275
Packages/black.kit.vrcui/package.json (2)
4-4: Version bump to 0.9.0 is appropriate.The version increase aligns with the scope of changes mentioned in PR objectives (new UI prefabs, renamed components).
27-29: Dependencies updated to latest minor versions.The updates to
black.kit.launchpadicons(^0.8.1) andcom.vrchat.worlds(^3.7.5) are minor version bumps, which should maintain backward compatibility.Let's verify the compatibility of these versions:
✅ Verification successful
Dependencies are correctly updated and compatible
The version updates are safe minor bumps that maintain backward compatibility. The dependency tree is clean with no version conflicts.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if these are the latest stable versions curl -s "https://api.vrchat.cloud/api/1/config" | jq '.clientApiKey' || echo "VRChat API check failed" # Look for any known issues with these versions gh api graphql -f query=' { repository(owner: "vrchat", name: "packages") { issues(last: 5, states: OPEN) { nodes { title body labels(first: 5) { nodes { name } } } } } }'Length of output: 381
Script:
#!/bin/bash # Search for usage of these packages echo "=== Searching for package usage ===" rg -l "black\.kit\.(launchpadicons|toybox)" --type json echo -e "\n=== Checking for version declarations ===" rg "\"(black\.kit\.(launchpadicons|toybox)|com\.vrchat\.worlds)\".*:.*\".*\"" --type json echo -e "\n=== Looking for potential compatibility markers ===" rg "requires|dependencies" --type json -A 5 -B 5Length of output: 34116
Packages/vpm-manifest.json (2)
13-22: Dependencies section properly updated.All version updates are consistent with package.json and follow proper semver patterns.
41-65: Locked dependencies properly configured.The locked dependencies section correctly specifies all required versions and their interdependencies. The dependency chain is properly maintained:
- black.kit.toybox -> com.vrchat.worlds ^3.7.4
- com.vrchat.worlds 3.7.5 -> com.vrchat.base 3.7.5
- net.ureishi.qvpen -> com.vrchat.worlds ^3.5.0
Let's verify there are no circular dependencies:
✅ Verification successful
Dependencies are properly configured with no circular references
The dependency graph forms a clean tree structure with com.vrchat.worlds as a shared dependency, and all version constraints are satisfied by the locked versions.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check for circular dependencies in the manifest jq -r '.locked | to_entries | .[] | select(.value.dependencies != null) | .key as $parent | .value.dependencies | to_entries[] | [$parent, .key] | @tsv' Packages/vpm-manifest.json | tsort --checkLength of output: 293
Script:
#!/bin/bash # Extract and analyze dependencies using jq jq -r ' def find_deps($pkg; $seen): if $pkg == null or ($seen | contains([$pkg])) then "Circular dependency detected: \($seen | join(" -> ")) -> \($pkg)" else .locked[$pkg].dependencies // {} | to_entries[] | .key as $dep | find_deps($dep; ($seen + [$pkg])) end; .locked | keys[] as $pkg | find_deps($pkg; []) ' Packages/vpm-manifest.jsonLength of output: 374
Overview
IconWithCaptionButtonprefab.InteractivePlayerCardprefab.Features
Molecules/Buttons/ExpandableButton: Removed the extra raycast targetMolecules/Buttons/IconWithCaptionButton: Implemented the expandable iconMolecules/Buttons/NavigationButton: Improved the layoutMolecules/Cards/CompactPlayerCardMolecules/Cards/CreditCard->Molecules/Cards/PurchaseCardMolecules/Cards/GroupWithTab: Improved the layoutMolecules/Cards/PlayerCard: Improved the layoutMolecules/Cards/SocialWithTab: Improved the layoutMolecules/Cards/WorldWithTab: Improved the layoutOrganisms/Category/AvatarMenu: Removed the extra iconOrganisms/Category/SocialMenu: Removed the extra iconOrganisms/Wings/WingsRootMenuOrganisms/Mock/QuickMenuBug fixes
Molecules/Cards/InteractivePlayerCardUpdate for the sample world
CI/CD
Other updates
Summary by CodeRabbit
Release Notes
New Features
Dependency Updates
black.kit.vrcuipackage to version 0.9.0Workflow Improvements
Development Tools