Solve possible UnboundLocalError. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Happened to me (see below). I know handling this case could be done different (stop/return after closing the socket probably), but my insight to the possible consequences is limited so i opted for the obvious solution to declare "bytes_written" ...
Traceback (most recent call last):
File "/usr/bin/parallel-ssh", line 119, in <module>
do_pssh(hosts, cmdline, opts)
File "/usr/bin/parallel-ssh", line 110, in do_pssh
manager.run()
File "/usr/lib/pymodules/python2.6/psshlib/manager.py", line 67, in run
self.iomap.poll(wait)
File "/usr/lib/pymodules/python2.6/psshlib/manager.py", line 242, in poll
handler(fd, self)
File "/usr/lib/pymodules/python2.6/psshlib/askpass_server.py", line 77, in handle_write
buffer = buffer[bytes_written:]
UnboundLocalError: local variable 'bytes_written' referenced before assignment
|
It seems to me that we should return at the end of the catch. But it is also good practice to declare variables before their use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happened to me (see below). I know handling this case could be done different (stop/return after closing the socket probably), but my insight to the possible consequences is limited so i opted for the obvious solution to declare "bytes_written" ...
Traceback (most recent call last):
File "/usr/bin/parallel-ssh", line 119, in
do_pssh(hosts, cmdline, opts)
File "/usr/bin/parallel-ssh", line 110, in do_pssh
manager.run()
File "/usr/lib/pymodules/python2.6/psshlib/manager.py", line 67, in run
self.iomap.poll(wait)
File "/usr/lib/pymodules/python2.6/psshlib/manager.py", line 242, in poll
handler(fd, self)
File "/usr/lib/pymodules/python2.6/psshlib/askpass_server.py", line 77, in handle_write
buffer = buffer[bytes_written:]
UnboundLocalError: local variable 'bytes_written' referenced before assignment