Fix daily quests #1056
Merged
Fix daily quests #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nico-Sanchez
force-pushed
the
gh-1053-fix-daily-quests
branch
from
824e598 to
756b34d
Compare
manucamejo
previously approved these changes
Jan 23, 2025
manucamejo
approved these changes
Jan 24, 2025
tvillegas98
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
Merge alongside https://github.com/lambdaclass/champions_of_mirra/pull/2414
Motivation
Quests are too complex and aren't working properly.
Closes #1053
Summary of changes
How to test it?
Just play with the front branch and complete the quests.
To test faster, you can change the quest_descriptions.json and make them all 1 kill to complete.
Checklist