-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps-dev): bump @rollup/plugin-commonjs from 26.0.1 to 28.0.2 #487
base: main
Are you sure you want to change the base?
chore(deps-dev): bump @rollup/plugin-commonjs from 26.0.1 to 28.0.2 #487
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer: Experimental PR review
PR Summary
This PR updates the @rollup/plugin-commonjs package with significant breaking changes that could affect the build process across multiple packages in the monorepo.
- Breaking change in
strictRequires
defaulting to true may affect how CommonJS modules are handled inrollup.config.js
- Package switch to
fdir
for dependency management could impact build performance across all workspace packages - Multiple packages (
langfuse-core
,langfuse-node
,langfuse-langchain
,langfuse-vercel
) need testing due to shared build configuration - Integration tests in
/integration-test/modules
are critical to verify module loading still works correctly - Build process needs verification across both CommonJS and ESM outputs as specified in each package's exports field
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Bumps [@rollup/plugin-commonjs](https://github.com/rollup/plugins/tree/HEAD/packages/commonjs) from 26.0.1 to 28.0.2. - [Changelog](https://github.com/rollup/plugins/blob/master/packages/commonjs/CHANGELOG.md) - [Commits](https://github.com/rollup/plugins/commits/commonjs-v28.0.2/packages/commonjs) --- updated-dependencies: - dependency-name: "@rollup/plugin-commonjs" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
7c84e38
to
7ae5f17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer: Experimental PR review
PR Summary
This update to @rollup/plugin-commonjs introduces significant changes that warrant careful testing of the build system. Based on the latest changes and files provided:
Integration test coverage has been expanded to verify module compatibility across different environments:
- Added comprehensive module format testing in
/integration-test/modules
with dedicated test scripts for CJS, ESM, and TypeScript configurations - Test scripts now cover both Node.js and TypeScript module resolution with
nodenext
and CommonJS targets - Integration tests validate proper exports across different module systems through
tsconfig
configurations
The key points to verify with this update are:
- Verify build outputs work correctly with
strictRequires: true
default in the new version - Ensure TypeScript compilation remains compatible with both ESM and CJS output formats
- Test module resolution across Node.js and TypeScript environments using the integration test suite
- Monitor build performance changes due to the switch to
fdir
for dependency scanning
I recommend proceeding with the update while closely monitoring the integration test results to catch any potential module resolution issues early.
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
@@ -53,7 +53,7 @@ | |||
"@opentelemetry/sdk-node": "^0.53.0", | |||
"@opentelemetry/sdk-trace-node": "^1.25.1", | |||
"@rollup/plugin-babel": "^6.0.3", | |||
"@rollup/plugin-commonjs": "^26.0.1", | |||
"@rollup/plugin-commonjs": "^28.0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: strictRequires is now true by default in v27+. May need to explicitly set to false if any packages rely on the previous behavior.
Bumps @rollup/plugin-commonjs from 26.0.1 to 28.0.2.
Changelog
Sourced from
@rollup/plugin-commonjs
's changelog.Commits
97e17ce
chore(release): commonjs v28.0.23efaf75
docs(commonjs):output.exports
recommendation also applies to IIFE (#1810)0f45234
chore(release): commonjs v28.0.1dd1deee
chore(commonjs): upgrade picomatch (#1775)0af45c2
chore(release): commonjs v28.0.0c2a05eb
chore(commonjs): switch to fdir for fewer dependencies (#1741)b6fa3b1
chore(release): commonjs v27.0.08f02987
feat(commonjs)!: default strictRequires to true (#1639)274b72c
chore(repo): cherry-pick. commonjs. replace top-level this with exports name ...e2a7195
chore(release): commonjs v26.0.3Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)