Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): link dataset item positional arg #1062

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

hassiebp
Copy link
Contributor

@hassiebp hassiebp commented Jan 6, 2025

Important

Reorder trace_or_observation parameter in link() in langfuse/client.py to be the first positional argument.

  • Function Signature Change:
    • Reorder trace_or_observation parameter in link() in langfuse/client.py to be the first positional argument.
    • Update docstring in link() to reflect the new parameter order.

This description was created by Ellipsis for 5e5e46f. It will automatically update as commits are pushed.

@hassiebp hassiebp merged commit 310a142 into main Jan 6, 2025
6 of 8 checks passed
@hassiebp hassiebp deleted the revert-dataset-link branch January 6, 2025 09:54
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disclaimer: Experimental PR review

PR Summary

Changes the order of parameters in the link method of DatasetItemClient class in /langfuse/client.py, making trace_or_observation the first positional argument.

  • Reverts parameter order in link method to have trace_or_observation as first positional argument instead of run_name
  • Could break existing code that relies on positional argument order rather than keyword arguments
  • Affects dataset item linking functionality used to associate items with observations in dataset runs

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant