[0.5.x] Handle missing onError callback (#102)

* Unify submit functions * Handle missing onError callback
laravel · Oct 22, 2024 · f01ef8a · f01ef8a
1 parent dfad1ec
commit f01ef8a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 17 deletions.
diff --git a/packages/react-inertia/src/index.ts b/packages/react-inertia/src/index.ts
@@ -160,26 +160,18 @@ export const useForm = <Data extends Record<string, unknown>>(method: RequestMet
             return form
         },
         submit(submitMethod: RequestMethod | Config = {}, submitUrl?: string, submitOptions?: any): void {
-            const isPatchedCall = typeof submitMethod !== 'string'
-
-            submitOptions = isPatchedCall
-                ? submitMethod
-                : submitOptions
-
-            submitUrl = isPatchedCall
-                ? resolveUrl(url)
-                : submitUrl!
-
-            submitMethod = isPatchedCall
-                ? resolveMethod(method)
-                : submitMethod as RequestMethod
+            if (typeof submitMethod !== 'string') {
+                submitOptions = submitMethod
+                submitUrl = resolveUrl(url)
+                submitMethod = resolveMethod(method)
+            }
 
-            inertiaSubmit(submitMethod, submitUrl, {
+            inertiaSubmit(submitMethod, submitUrl!, {
                 ...submitOptions,
                 onError: (errors: SimpleValidationErrors): any => {
                     precognitiveForm.validator().setErrors(errors)
 
-                    if (submitOptions.onError) {
+                    if (submitOptions?.onError) {
                         return submitOptions.onError(errors)
                     }
                 },

diff --git a/packages/vue-inertia/src/index.ts b/packages/vue-inertia/src/index.ts
@@ -178,8 +178,8 @@ export const useForm = <Data extends Record<string, unknown>>(method: RequestMet
                 onError: (errors: SimpleValidationErrors): void => {
                     precognitiveForm.validator().setErrors(errors)
 
-                    if (submitOptions!.onError) {
-                        return submitOptions!.onError(errors)
+                    if (submitOptions?.onError) {
+                        return submitOptions.onError(errors)
                     }
                 },
             })