Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.5.x] Fix incorrectly reported valid inputs #60

Merged
merged 3 commits into from
Jan 8, 2024
Merged

[0.5.x] Fix incorrectly reported valid inputs #60

merged 3 commits into from
Jan 8, 2024

Conversation

timacdonald
Copy link
Member

@timacdonald timacdonald commented Jan 8, 2024 •
edited
Loading

fixes #58

It is possible for Precognition to get out of sync with what inputs are reported as being "valid".

This fixes the issue by:

  1. Delaying listeners until all state has been updated.
  2. Making sure the library specific implementations update their "valid" state when errors change.

Note: The reported "invalid" inputs are always correct and not impacted by this bug.

@timacdonald timacdonald mentioned this pull request Jan 8, 2024
Closed
@taylorotwell taylorotwell merged commit 492ce3c into main Jan 8, 2024
2 checks passed
@taylorotwell taylorotwell deleted the valid-fix branch January 8, 2024 14:59
@driesvints driesvints changed the title [0.8.x] Fix incorrectly reported valid inputs [0.5.x] Fix incorrectly reported valid inputs Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Form reporting incorrectly valid
2 participants
@timacdonald @taylorotwell