Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.5.x] Migrate to lodash-es #62

Merged
merged 4 commits into from Jan 23, 2024
Merged

[0.5.x] Migrate to lodash-es #62

merged 4 commits into from Jan 23, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jan 22, 2024

This pull request represents a significant enhancement to our project's dependency management and security posture. We are transitioning from using individual lodash packages to the unified lodash package. This change is motivated by two primary factors: the discontinuation of maintenance for individual lodash modules and a critical security vulnerability in lodash.set.

Key changes:

  • Unified Lodash Package: All individual lodash packages (lodash.*) are replaced with the single, comprehensive lodash package. This consolidation simplifies dependency management and ensures we are using the most up-to-date and supported version of lodash.

  • Security lodash.set: The individual lodash.set package currently utilized in our project has a known prototype pollution vulnerability (CWE-1321). By switching to the unified lodash package, we address this security issue, as the latest version of lodash has resolved this vulnerability.

Scope:

  • Only focus on the react package for now

@taylorotwell taylorotwell marked this pull request as draft January 22, 2024 13:57
@taylorotwell
Copy link
Member

taylorotwell commented Jan 22, 2024

Drafting until @timacdonald can review.

@timacdonald timacdonald changed the title fix(sec): updated react package to unified lodash due to CWE-1321 [0.5.x] Migrate to lodash-es Jan 23, 2024
@timacdonald timacdonald marked this pull request as ready for review January 23, 2024 01:57
@taylorotwell taylorotwell merged commit fb6276f into laravel:main Jan 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants