Process global options once per package

[josephwright]

Internal housekeeping

Status of pull request

• Feedback wanted
• Under development
• Ready to merge

Checklist of required changes before merge will be approved

• Test file(s) added
• Version and date string updated in changed source files
• Relevant \changes entries in source included
• Relevant changes.txt updated
• Rollback provided (if necessary)?
• ltnewsX.tex (and/or latexchanges.tex) updated

[josephwright]

@Skillmon Could you review here?

[josephwright]

No rollback here: this is purely suppressing some stray warnings and there should be no sense in which people need the older behaviour.

[FrankMittelbach]

one typo noticed

[davidcarlisle]

Seems to work well with my own tests with and without usage=load

[Skillmon]

I'd additionally add the following test file:

\begin{filecontents*}[overwrite]{testpackage.sty}
\ProvidesExplPackage{testpackage}{2025-02-04}{}{}
\keys_define:nn { testpackage }
  {
    testoption .code:n = { \def \testmacro { #1 } } ,
    testoption .usage:n = load
  }
\ProcessKeyOptions [ testpackage ]
\endinput
\end{filecontents*}

\input{test2e}

\documentclass[testoption = false]{article}

\START

\usepackage[testoption = true]{testpackage}
\usepackage[testoption = ERROR]{testpackage}

\TYPE{\testmacro}

\END

(should type true)

[Skillmon]

The, imho, much bigger issue than these spurious warnings is that load options are applied just once while every other option is applied multiple times (potentially overwriting any explicitly set option for this package). But otherwise the wording is fine. This is just a note, not a request for change.

[Skillmon]

Missing EOL.