refactor(cli): replace promptly with dialoguer #3669
Conversation
|
Ironically, we previously replaced Did |
|
Alternatively, since we don't really need anything super fancy, we could just roll our own prompts, couldn't we? |
|
If it's a just a matter of handling Ctrl-C/SIGINT, we can do that through Tokio, but we'd need to run the |
It still happens.
Disappointing 🙄
I may have a simpler idea but first I have to figure out how to restore the cursor. |
|
paolobarbolini
force-pushed
the
promptly-to-dialoguer
branch
from
931540c to
8bcfc67
Compare
paolobarbolini
force-pushed
the
promptly-to-dialoguer
branch
from
8bcfc67 to
62112e5
Compare
| println!("{e}"); | ||
| return false; | ||
| async fn ask_to_continue_drop(db_url: String) -> bool { | ||
| struct RestoreCursorGuard { |
There was a problem hiding this comment.
It'd be a good idea to comment on why this is necessary.
|
|
||
| select! { | ||
| biased; | ||
| _ = ctrlc_fut => { |
There was a problem hiding this comment.
Should mention why we need to explicitly handle Ctrl-C.
Turns out #3665 didn't fully fix the build for loongarch64 and s390x because the
promptlycrate depends on an old version ofnix. While looking more into it I found thatpromptlyis unmaintained and is used very little (judging by the reverse dependencies on crates.io and number of downloads). I've decided to replace it withdialoguer, maintained byconsole-rsorg from which other crates sqlx-cli is already depending on.This also happens to reduce the number of indirect dependencies, which is nice.