-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server: buildx for server images #11582
base: dev
Are you sure you want to change the base?
Conversation
Do you know how difficult it would be to add ARM64 support if this pull request is merged? It seems to be particularly challenging to add since several people (including myself) unsuccessfully tried. |
Most likely one line to Docker descriptor and a line to place from were you trigger image building. |
Oh, BTW I just realized that I have not checked your GH actions. Perhaps we should adjust this workflow and think about proper builder for arm (sorry I knows nothing about your workers infrastructure). |
Indeed any new dependencies should be added there, but I guess the check would tell us that - if it's still passing it's probably that the new dependency is already included as part of something else, and so we don't need to change anything. |
`--addLatestTag` will force `latest` tag creation even for pre-release versions
Just run `yarn buildServerDocker`
5ae0d22
to
aa266fa
Compare
OK, server related checks - pass. Means we built at least However there are few more questions/ideas around this topic:
|
22da9d3
to
7d264e2
Compare
Switching to Docker BuildX toolset. It's faster, have more benefits for development process (e.g. caching mount points) and open possibility to build multi platform images.