Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server: buildx for server images #11582

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from

Conversation

redrathnure
Copy link
Contributor

Switching to Docker BuildX toolset. It's faster, have more benefits for development process (e.g. caching mount points) and open possibility to build multi platform images.

@laurent22
Copy link
Owner

Do you know how difficult it would be to add ARM64 support if this pull request is merged? It seems to be particularly challenging to add since several people (including myself) unsuccessfully tried.

@redrathnure
Copy link
Contributor Author

redrathnure commented Jan 9, 2025

Most likely one line to Docker descriptor and a line to place from were you trigger image building.
Will try to do at least first part today.

@redrathnure
Copy link
Contributor Author

Oh, BTW I just realized that I have not checked your GH actions. Perhaps we should adjust this workflow and think about proper builder for arm (sorry I knows nothing about your workers infrastructure).

@laurent22
Copy link
Owner

Indeed any new dependencies should be added there, but I guess the check would tell us that - if it's still passing it's probably that the new dependency is already included as part of something else, and so we don't need to change anything.

@redrathnure
Copy link
Contributor Author

OK, server related checks - pass. Means we built at least linux\amd64 image:)

However there are few more questions/ideas around this topic:

  1. Do you have arm64 based workers? If yes, it's possible to configure ServerDockerImage like step but for amr64 images.
  2. If you have only intel based worker but still would like to build/check arm64 server images, it's possible to run docker together with QEMU. It works but extremely slow. For me amd64 image takes 5-10 minutes, but arm64 with emulation it's more than 1hour.
  3. And I have no idea how you publish server images. If you build it manually (not via GH actions): please try a new cli arg --platform linux/amd64,platform/arm64 (build multiform image(s) without publishing). And now you may exec just yarn buildServerDocker to check all available args with human friendly help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants