feat: add telegram bot to lavap health #1862
Open
+140
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results2 389 tests +1 2 388 ✅ ±0 26m 23s ⏱️ +46s Results for commit 4d9a648. ± Comparison against base commit 537c7ca. This pull request removes 3 and adds 4 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
shleikes
requested changes
Dec 23, 2024
Comment on lines
39
to
55
| checkRequest: func(t *testing.T, r *http.Request) { | ||
| // Check method and content type | ||
| assert.Equal(t, "POST", r.Method) | ||
| assert.Equal(t, "application/json", r.Header.Get("Content-Type")) | ||
|
|
||
| // Read and verify request body | ||
| body, err := io.ReadAll(r.Body) | ||
| require.NoError(t, err) | ||
|
|
||
| // Check if body contains expected content | ||
| bodyStr := string(body) | ||
| assert.Contains(t, bodyStr, "Test Alert") | ||
| assert.Contains(t, bodyStr, "severity") | ||
| assert.Contains(t, bodyStr, "high") | ||
| assert.Contains(t, bodyStr, "service") | ||
| assert.Contains(t, bodyStr, "test-service") | ||
| }, |
There was a problem hiding this comment.
Why is this here and not inside the test itself?
There was a problem hiding this comment.
since not all scenatious need to check the request
shleikes
previously approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changemainbranchReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...