Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: switch to sharedarraybuffer to reduce serialization and messaging #14

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

sverben
Copy link
Member

@sverben sverben commented Sep 16, 2024

No description provided.

@sverben sverben requested a review from a team as a code owner September 16, 2024 17:59
writeAddress += initialLength;

if (writeAddress === window.writeBuffer.length) {
writeAddress = 3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why 3? Could use a comment

Copy link
Member

@rmoesbergen rmoesbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@koen1711
Copy link
Member

Will be reviewing shortly

@koen1711
Copy link
Member

Linux ✔️
Windows ✔️
MacOS 🕦

@sverben sverben merged commit 460324b into main Sep 19, 2024
1 check passed
@sverben sverben deleted the sharedarraybuffer branch September 19, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants