-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: ledger no request keys context #4888
Conversation
@314159265359879 , please, let me know if there are any other scenarios worth testing on this branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice refactor. Been wanting to get this done for ages!
src/app/features/ledger/generic-flows/tx-signing/use-ledger-sign-tx.ts
Outdated
Show resolved
Hide resolved
src/app/features/ledger/generic-flows/tx-signing/use-ledger-sign-tx.ts
Outdated
Show resolved
Hide resolved
I believe you covered them, very nice! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @edgarkhanzadian
Please rebase the merges before merging
ffe6690
to
5242a52
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Here's some testing of different scenarios:
ledgerTesting720.mov
Note: will squash commits together after approval