fix: runes formatted balance, closes #5293 #5313
Conversation
|
cc @brandonmarshall-tm this should be correct now?
EDIT: Previously... |
What is the issue bc that was just released? Are they not correct? What are you seeing? |
|
@brandonmarshall-tm sorry, I think I edited your comment by mistake. Pretty confident I did a quote reply thou 🤷♀️ |
|
Added a fix here for: #4408 (comment)
|
fbwoolf
force-pushed
the
fix/runes-formatted-balance
branch
from
6351442 to
79d94e9
Compare
| const balanceAsString = convertAmountToBaseUnit(rune.balance).toString(); | ||
| const formattedBalance = formatBalance(balanceAsString); |
There was a problem hiding this comment.
This is problematic, why doesn't formatBalance accept Money?
There was a problem hiding this comment.
Good point, I can change this.
There was a problem hiding this comment.
Really not sure I understand needing to change this when we need the string to display at this point? Why keep it as Money just to display it?
There was a problem hiding this comment.
Questioning only bc balanceAsString is used in more than one place and is done this way in several components to handle the formatting w/ tooltip.
|
When the number is very high I think we should ditch the "T" suffix and only show e+XX instead of e+_XX_T |
fbwoolf
force-pushed
the
fix/runes-formatted-balance
branch
from
79d94e9 to
4a67a60
Compare
|
Added a new issue to circle back to adding integrations tests for our asset list / token display. We need to add several new tokens to our test wallet as part of this effort. #5318 |
|
Not confident my conversion here is accurate, or the price data is off from BiS? Coingecko is showing $152... 
|
|
I think you're good @fbwoolf! These numbers and prices are looking much more accurate to me. Prices can vary widly across exchanges (second screenshot), so depending on where BIS or Coingecko are pulling from, you might see some pretty big swings. But before it was like 10x the amount so this is much more accurate than before.
|
|
decimals and suffixes looking good now, this is going in the next release (after 6.36.0 that just went live), right? |
This PR fixes a UI bug when we formatted the runes (and BRC-20) token balance. We needed to convert the amount to the base unit first, my bad.