fix: fix padding on back button, ref #25

[pete-watters]

Try out Leather build a4509c7 — Extension build, Test report, Storybook, Chromatic

This PR:

• makes an adjustment to arrow position on small view when prompting for password
• fixes a typo in analytics from chore: add defensive code and better analytics for broadcast errors, … #5375

Summary by CodeRabbit

• Improvements
  • Updated error tracking for more accurate analytics in the send inscription review process.
  • Enhanced header component to adjust padding dynamically based on the variant, improving the user interface during onboarding on small screens.

[coderabbitai]

Walkthrough

This update focuses on refining user tracking and UI responsiveness. The analytics event key in the SendInscriptionReview function was updated for consistency, and the Header component now adjusts its paddingLeft property based on the variant value for better visual alignment on small screens.

Changes

Files	Change Summary
src/app/pages/send/ordinal-inscription/send-inscription-review.tsx	Updated analytics event key from 'ordinalbroadcast__error' to 'broadcast_ordinal_error'.
src/app/ui/components/containers/headers/header.tsx	Adjusted paddingLeft property in the Header component based on the variant value for small screens.

In code, we tweak and gently mend,
Analytics track to better end.
Headers shift, align just right,
Onboarding screens now clear and bright.
With each small change, we pave the way,
For smoother apps, come what may.
🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a36dae4 and 27c9461.

Files selected for processing (2)

• src/app/pages/send/ordinal-inscription/send-inscription-review.tsx (1 hunks)
• src/app/ui/components/containers/headers/header.tsx (1 hunks)

Files skipped from review due to trivial changes (1)

• src/app/pages/send/ordinal-inscription/send-inscription-review.tsx

Additional comments not posted (1)

src/app/ui/components/containers/headers/header.tsx (1)

43-43: Responsive padding adjustment looks good. Ensure it doesn't negatively impact other variants or screen sizes.

Verification successful

---

The paddingLeft adjustment for the "onboarding" variant does not affect other variants or screen sizes, as the "onboarding" variant is not used elsewhere in the codebase.

Scripts Executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify that the paddingLeft adjustment does not affect other variants or screen sizes.

# Test: Search for usage of the `Header` component with different variants and screen sizes.
rg --type tsx $'(<Header variant={[^}]+})'

Length of output: 169

---

---

Script:

#!/bin/bash
# Description: Verify that the paddingLeft adjustment does not affect other variants or screen sizes.

# Test: Search for usage of the `Header` component with different variants and screen sizes.
rg --type tsx '<Header[^>]*variant=[^>]+>'

Length of output: 72

---

---

Script:

#!/bin/bash
# Description: Verify that the paddingLeft adjustment does not affect other variants or screen sizes.

# Test: Search for usage of the `Header` component with different variants and screen sizes.
rg '<Header[^>]*variant=[^>]+>' --glob '*.tsx'

Length of output: 48

---

---

Script:

#!/bin/bash
# Description: Verify that the paddingLeft adjustment does not affect other variants or screen sizes.

# Test: Search for usage of the `Header` component in `.tsx` files.
rg '<Header' --glob '*.tsx'

Length of output: 769

---

---

Script:

#!/bin/bash
# Description: Verify that the paddingLeft adjustment does not affect other variants or screen sizes.

# Test: Search for the `variant` prop usage within the identified files.
rg 'variant=' src/app/pages/swap/components/swap-asset-dialog/swap-asset-dialog-quote.tsx src/app/pages/swap/components/swap-asset-dialog/swap-asset-dialog-base.tsx src/app/pages/receive/receive-dialog.tsx src/app/pages/receive/components/receive-tokens.layout.tsx src/app/features/container/container.tsx

Length of output: 745

[kyranjamie]

Commit reference the wrong issue, needs full qualifier if referencing issues repo

[pete-watters]

Commit reference the wrong issue, needs full qualifier if referencing issues repo

Thanks. I wasn't sure how to link / reference.

So I can fix it, what do you mean exactly by full qualifier?

I couldn't find any other examples in git log

[kyranjamie]

leather-wallet/issues#25

https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/autolinked-references-and-urls#:~:text=Organization_name/Repository%23

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 27c9461 and a4509c7.

Files selected for processing (2)

• src/app/pages/send/ordinal-inscription/send-inscription-review.tsx (1 hunks)
• src/app/ui/components/containers/headers/header.tsx (1 hunks)

Files skipped from review as they are similar to previous changes (2)

• src/app/pages/send/ordinal-inscription/send-inscription-review.tsx
• src/app/ui/components/containers/headers/header.tsx