-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: upgrade stacks js, closes LEA-1989 #6076
base: dev
Are you sure you want to change the base?
Conversation
Dependent on changes installed from here: leather-io/mono#796 |
@kyranjamie I'm testing the changes here, but can you look over my changes to the stacks private and public key code changes? And, stacks.js removed |
I'll get to testing this when I've fixed some tests for the returning txid issue. But re this, I'd make sure they're backwards compatible. Do these new methods decrypt payloads made before v7? Pretty sure they won't, so then we'll have to have some migration step, or bring over the old encryption methods from v6. |
I tested going from dev > to this branch, creating a wallet > locking > then unlocking each way and did not hit any errors. Would love for you to test too though just to make sure works on your end. Maybe the change is ok? https://github.com/hirosystems/stacks.js/blob/main/.github/MIGRATION.md#triplesec EDIT: This was the code removed with aliased methods: |
Something isn't quite right bc running into this restoring the test wallet. Balances are correct, but BNS name lookup is incorrect and appears to only restore one account. Looking into it... EDIT: Loading, but a few BNS names are funky 🤔 EDIT: This appears to actually be a bug with BNS changes in the mono repo upgrade, so looking at fixing there. |
ab265bb
to
0c92d71
Compare
@kyranjamie all seems to be working when I test now so opening up for your code review. Tests will be broken until I actually install mono repo changes, but hoping you will look over when can. |
29648bc
to
9e917d1
Compare
Alright let's try getting this out the door. Testing this now with changes you've also pushed to mono 👨🏼💻 |
I ran into an issue last night trying to do a swap. Bc Bitflow sends us ClarityValues from 6.17.0, when we serialize we get an error. |
199c19e
to
3a79248
Compare
Upgrades all stacks.js pkgs to
7.0.2
.