feat(signPsbt): add txid to return payload #6078
Merged
+209
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranjamie
force-pushed
the
feat/return-txid
branch
from
1ef4155 to
75b921c
Compare
fbwoolf
approved these changes
Jan 22, 2025
kyranjamie
force-pushed
the
feat/return-txid
branch
from
75b921c to
89ee0d4
Compare
kyranjamie
force-pushed
the
feat/return-txid
branch
from
89ee0d4 to
c508dd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5292
In this PR, we now return the
txidwhen an app has requested that the tx be broadcast.I had a hard time working with the
signPsbttests. They were hard coded, because a previous version of Playwright didn't support ESM imports. This was since fixed, enabling a refactor of the tests to generate the transaction being tested as part of the tests.Also added is another test to verify that failed broadcasts also return to the app
Tests running
2025-01-22-000398.mp4