Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint fixes #2

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Lint fixes #2

wants to merge 4 commits into from

Conversation

legobeat
Copy link
Owner

@legobeat legobeat commented Sep 12, 2023 •
edited
Loading

Description

Contains the following linting-related fixes:

  • ci: Skip linting job in nodejs v12, v14
  • ci: add --ignore-engines to yarn [install] invocations
    • some devDeps depend on nodejs v14. This change can be reverted once nodejs v12 support has been dropped.
  • lint(test): ignore import/no-unresolved violation by importing dist
  • ci: disable linting of non-existing CHANGELOG.md

@legobeat
ci: ignore engines restrictions on yarn install
cf39ffb 
@metamask/eslint-config@10 is not compatible with Node.js v12.
This change and its addition of the `--ignore-engines` flag can be removed
once Node.js v12 support has been dropped.
@legobeat
ci: skip lint job for EoL nodejs versions
c2150e6
@legobeat
lint(test): ignore import/no-unresolved of dist
d2fe5aa
@legobeat
ci: disable linting of changelog since there is none
c9bca2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@legobeat