Apply standard template and formatting #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -48,7 +48,7 @@ def partition_rows(data, partitions, *, rng_spec=None): | |||
| # convert each partition into a split | |||
| for i, ts in enumerate(test_sets): | |||
| test = data.iloc[ts, :] | |||
| trains = test_sets[:i] + test_sets[(i + 1):] | |||
| trains = test_sets[:i] + test_sets[(i + 1) :] | |||
| @@ -132,8 +136,8 @@ | |||
| # convert each partition into a split | |||
| for i in range(n): | |||
| start = i * size | |||
| test = xs[start:start + size] | |||
| train = np.concatenate((xs[:start], xs[start + size:])) | |||
| test = xs[start : start + size] | |||
| test = xs[start:start + size] | ||
| train = np.concatenate((xs[:start], xs[start + size:])) | ||
| test = xs[start : start + size] | ||
| train = np.concatenate((xs[:start], xs[start + size :])) |
| self.n = n | ||
| self.column = col | ||
|
|
||
| def __call__(self, udf): | ||
| return udf.sort_values(self.column).iloc[-self.n:] | ||
| return udf.sort_values(self.column).iloc[-self.n :] |
| @@ -322,12 +330,12 @@ | |||
| for i in range(partitions): | |||
| # get our test users! | |||
| if disjoint: | |||
| test_us = users[i*size:(i+1)*size] | |||
| test_us = users[i * size : (i + 1) * size] | |||
| ) | ||
| if self.aggregate == "weighted-average": | ||
| _logger.warning( | ||
| "item-item configured to ignore ratings, but using weighted averages - likely bug" |
There was a problem hiding this comment.
Line too long (102 > 100 characters)
|
Code Climate has analyzed commit 2c1adf8 and detected 7 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #349 +/- ##
==========================================
+ Coverage 90.16% 90.79% +0.63%
==========================================
Files 41 41
Lines 3234 3119 -115
==========================================
- Hits 2916 2832 -84
+ Misses 318 287 -31
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies our standard LK project template and reformats the code with Ruff. Closes #342.