Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accelerate item-item k-NN algorithms #578

Merged
merged 6 commits into from
Dec 27, 2024

Conversation

mdekstrand
Copy link
Member

This significantly speeds up the item-item k-NN algorithm's scoring performance (by up to an order of magnitude).

It also removes the history lookup logic, so the k-NN scorer needs to be used with a history lookup component.

@mdekstrand mdekstrand added components LensKit recommendation components performance labels Dec 27, 2024
@mdekstrand mdekstrand added this to the 2025.1 milestone Dec 27, 2024
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.57%. Comparing base (8418807) to head (6009cc9).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #578      +/-   ##
==========================================
- Coverage   90.68%   90.57%   -0.12%     
==========================================
  Files         107      108       +1     
  Lines        6624     6557      -67     
==========================================
- Hits         6007     5939      -68     
- Misses        617      618       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdekstrand mdekstrand merged commit 88fc375 into lenskit:main Dec 27, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
components LensKit recommendation components performance
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant