ansible: Allow passing tmpfs options #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the only option passed to tmpfs is `exec` so tmpfs is mounted
with "exec" option.
We may need to pass extra options on some runners, like setting the size
of tmpfs for instance (docker seems to default to 50% of the host
memory), and only on specific hosts, so we need this to be somwhat
configurable.
Add a new variable `runner_tmpfs_options` which defaults to `['exec']`
and can be overridden at the host/group level.
Test, after setting a host to use:
```
runner_tmpfs_options:
- exec
- size=12G
```
running ansible in dry-run mode:
```
--- before: /etc/systemd/system/[email protected]
+++ after:
/home/chantra/.ansible/tmp/ansible-local-3819115bni8m1fy/tmp65ktafym
@@ -15,7 +15,7 @@
--health-cmd='(ss -ntp -H dport = :443 | grep -q ESTAB) ||
exit 1' \
--health-start-period=60s --health-interval=30s \
--health-timeout=5s --health-retries=3 \
- --tmpfs /tmp/work:exec \
+ --tmpfs /tmp/work:exec,size=12G \
--rm \
--env-file
"/etc/actions-runner/actions-runner-kernel-patches-worker-%i.env" \
--env-file
"/etc/actions-runner/actions-runner-kernel-patches-worker-%i-ghtoken.env"
\
```
And for a hosts with no override, running ansible does not chasnge
anything.
Signed-off-by: Manu Bretelle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the only option passed to tmpfs is
execso tmpfs is mounted with "exec" option.We may need to pass extra options on some runners, like setting the size of tmpfs for instance (docker seems to default to 50% of the host memory), and only on specific hosts, so we need this to be somwhat configurable.
Add a new variable
runner_tmpfs_optionswhich defaults to['exec']and can be overridden at the host/group level.Test, after setting a host to use:
running ansible in dry-run mode:
And for a hosts with no override, running ansible does not chasnge anything.