Factor out tar-artifacts action #148
Conversation
theihor
force-pushed
the
tar-artifacts
branch
4 times, most recently
from
c9ad352 to
0858df1
Compare
Rework tar-artifact.sh script, making it suitable for use as an independent github action. Use tar -rf (append) to accumulate files of interest before compressing with zstd. Control groups of artifacts to include (e.g. selftests/bpf, selftests/sched_ext) with environment variables.
theihor
force-pushed
the
tar-artifacts
branch
from
0858df1 to
771f785
Compare
| uses: ./tar-artifacts | ||
| env: | ||
| ARCHIVE_BPF_SELFTESTS: 'true' | ||
| ARCHIVE_MAKE_HELPERS: ${{ github.repository != 'kernel-patches/bpf' && 'true' || '' }} |
There was a problem hiding this comment.
thought for later: maybe we should move this out of libbpf/ci eventually and let the caller set it through an env var or input (probably preferred)
There was a problem hiding this comment.
Right, this is why I made them env vars in the first place. They are set in the workflow step right now, I guess you're talking about a case when the workflow itself is called from outside.
When we figure out how to actually use reusable workflows in kernel-patches/vmtest, this might be worth revisiting.
tar-artifacts/action.yml
Outdated
| toolchain: | ||
| required: true | ||
| outputs: | ||
| archive-name: | ||
| description: 'Artifacts tarball name' | ||
| value: ${{ steps.run-script.outputs.archive-name }} |
There was a problem hiding this comment.
toolchain is only needed so we can generate the final archive name. I wonder if we should rather provide the destination file as an input, this way we can give it the name we like from the caller.
It also seems to be what other actions doing something similar would do: https://github.com/marketplace/actions/tar-action
There was a problem hiding this comment.
Added archive input and removed output.
I thought about this, and wasn't sure what's the best API would be. The caller obviously needs to know the archive name, so why don't just allow them to set it.
Also, it seems so far that using env variables to control action-driven scripts is very convenient. We should think about a convention for when to use env variables vs script argument vs action inputs, because right now it's quite chaotic.
There was a problem hiding this comment.
because right now it's quite chaotic.
could not agree more :D
* Remove `archive-name` output * Remove `toolchain` input * Add `archive` input, setting the path to output .zst archive * Set ARCH env variable instead of passing a script argument
Rework tar-artifact.sh script, making it suitable for use as an independent github action.
Use tar -rf (append) to accumulate files of interest before compressing with zstd.
Control groups of artifacts to include (e.g. selftests/bpf, selftests/sched_ext) with environment variables.