-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added hid_send_output_report() function #677
Conversation
So far I haven't encountered cases when you have to use Most implementations of On some platforms, the implementation of |
I've tried |
Wouldn't it be better to read the |
Not sure what do you mean. I didn't check the linux/hidraw implementation, but Windows and macOS implementation is not exactly known. |
45124fb
to
6ef7760
Compare
- added `hid_send_output_report` reference in function description for `hid_write` - added see `hid_write` reference in function description for `hid_send_output_report` - modified `hid_send_output_report` for windows to be more in line with `hid_send_feature_report` - `hid_write` for libusb now calls `hid_send_output_report` if there is no interrupt out endpoint to prevent code duplication
6ef7760
to
8e195d9
Compare
I'm pretty sure that's what we do on libusb backend. |
Where hid_get_input_report() was already available for some time, hid_send_output_report() was still missing.
We have used our own fork with this function added for a couple of years now, but believe it's better to add this to the main repository as well.
The changes are tested for Windows and on Linux (hidraw and libusb).
The functions for mac and netbsd are also added but not tested, since we currently have no hardware available for that. It would be great if somebody can test this function for those platforms as well, but the functions are very straightforward so I don't expect any issues with them.