New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

directly use pwned k-anonymity api #16633

Merged

ornicar merged 1 commit into master from pwned-direct

Dec 20, 2024

Member

niklasf commented Dec 20, 2024 •

edited

Loading

reconsidering if we should use the public api directly. unlike some other offered apis, there's essentially no rate limiting for the k-anonymity api.

pros:

new password leaks immediately reflected
can retire https://github.com/lichess-org/lila-pwned, for one less service to maintain

cons:

request latency: 30ms (was a bit surprised, but manta and rubik are in different data centers) -> ~60ms


          directly use pwned k-anonymity api

2d86ba4

Collaborator

ornicar commented Dec 20, 2024

Where it is used, the extra latency shouldn't be a problem.

ornicar merged commit 9141574 into master

7 checks passed

niklasf deleted the pwned-direct branch

December 20, 2024 19:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet